Make systemtest runs portable and re-runnable from CI artifacts#724
Open
PranjalManhgaye wants to merge 1 commit into
Open
Make systemtest runs portable and re-runnable from CI artifacts#724PranjalManhgaye wants to merge 1 commit into
PranjalManhgaye wants to merge 1 commit into
Conversation
MakisH
added
systemtests
GSoC
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make system test run directories portable and re-runnable from downloaded CI artifacts by switching generated Docker Compose files to relative paths, adding a local rerun helper script, updating default tutorial refs, and documenting the workflow.
Changes:
- Generate Docker Compose files using relative paths (intended to avoid CI-runner-specific absolute paths).
- Create a
rerun_systemtest.shhelper script inside each system test run directory. - Update
TUTORIALS_REFdefaults todevelopand document how to rerun tests from CI artifacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/tests/systemtests/Systemtest.py | Switches compose generation to relative paths and adds a rerun helper script. |
| tools/tests/components.yaml | Updates default TUTORIALS_REF from master to develop. |
| tools/tests/README.md | Adds documentation for rerunning system tests from CI artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@MakisH i have resolved the suggested changes by copilot , review it once , thanks |
MakisH
changed the title
PranjalManhgaye
force-pushed
the
fix-clean-scripts
branch
2 times, most recently
from
9e05394 to
558edba
Compare
Use relative Docker Compose paths, generate rerun_systemtest.sh in each run folder, and document replay from system_tests_run_*_full artifacts. Closes precice#387.
PranjalManhgaye
force-pushed
the
fix-clean-scripts
branch
from
558edba to
ddd0eac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a system test fails in CI, we often download the
system_tests_run_*_fullartifact to debug locally (#387). The old compose files used absolute runner paths, so replay on another machine usually broke unless you fixed paths by hand.This PR makes run folders portable: relative paths, a
rerun_systemtest.shhelper,TUTORIALS_REFdefaultdevelop, and short README notes on replay.Closes #387.
What changed
Systemtest.py:run_directory→"..", dockerfiles →../tools/tests/dockerfiles/<PLATFORM>, plusrerun_systemtest.sh(same commands as the Python runner). ( only + 66 -6 )README.md: how to unzip a full artifact and re-run.changelog-entries/724.mdAfter unzip, layout is
runs/tools/(shared) + one folder per test; you work inside the test folder.Testing
I tested locally with quickstart (build, run, fieldcompare),
rerun_systemtest.sh(original + copied tree), and one CI artifact replay. I did not run the fulltests.yamlmatrix here — happy if you trigger system tests on CI.The #387 example artifact is expired; new runs after merge should work without path patching.