Skip to content

Gate gather-refs on trigger-system-tests label in PR workflow#733

Closed
PranjalManhgaye wants to merge 1 commit into
precice:developfrom
PranjalManhgaye:fix-682-gate-gather-refs
Closed

Gate gather-refs on trigger-system-tests label in PR workflow#733
PranjalManhgaye wants to merge 1 commit into
precice:developfrom
PranjalManhgaye:fix-682-gate-gather-refs

Conversation

@PranjalManhgaye

Copy link
Copy Markdown
Collaborator

Fix #682 (part 1)

The System tests (PR) workflow runs on any pull_request: labeled event. Previously, gather-refs ran for every label add (making 7 GitHub API calls), while run-system-tests only ran when the label was trigger-system-tests. This wasted API quota for labels like "bug" or "GSoC".

This PR gates the gather-refs job on the same condition as run-system-tests:
if: github.event.label.name == 'trigger-system-tests'

The workflow now skips entirely for non-trigger labels, reducing GitHub API usage.

Per maintainer feedback in #723, authentication (token/App ID) is deferred and can be added separately if rate limits persist.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in changelog-entries/682.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes when merging.

Fix precice#682 (part 1). Reduces GitHub API usage by skipping the workflow
entirely when PRs are labeled with something other than trigger-system-tests.

Made-with: Cursor
@MakisH MakisH added systemtests GSoC Contributed in the context of the Google Summer of Code labels Mar 1, 2026
@kishansinghifs1

Copy link
Copy Markdown
Contributor

Can closed this as duplicate of #723.

@PranjalManhgaye

Copy link
Copy Markdown
Collaborator Author

thanks for the comment. I opened #733 as the minimal part 1 fix for #682 after the discussion in #723 (just gating gather-refs on the trigger-system-tests label, without auth changes). From my side I’m happy for maintainers to merge whichever PR they prefer and close the other as duplicate

@precice-bot

Copy link
Copy Markdown
Collaborator

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/gsoc-2026-pranjal-manhgaye/2769/6

@MakisH

MakisH commented Mar 23, 2026

Copy link
Copy Markdown
Member

Thank you both for addressing this. I will indeed close this one as duplicate of #723.

In general, whenever there is a PR under review, a better use of resources is to help refine the respective PR, than start a new one, unless the first is abandoned (for which I would expect at least several weeks of inactivity, in most cases).

@MakisH MakisH closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate GSoC Contributed in the context of the Google Summer of Code systemtests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest components workflow hits API usage limits

4 participants