Gate gather-refs on trigger-system-tests label in PR workflow#733
Closed
PranjalManhgaye wants to merge 1 commit into
Closed
Gate gather-refs on trigger-system-tests label in PR workflow#733PranjalManhgaye wants to merge 1 commit into
PranjalManhgaye wants to merge 1 commit into
Conversation
Fix precice#682 (part 1). Reduces GitHub API usage by skipping the workflow entirely when PRs are labeled with something other than trigger-system-tests. Made-with: Cursor
2 tasks
Contributor
|
Can closed this as duplicate of #723. |
Collaborator
Author
Collaborator
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-pranjal-manhgaye/2769/6 |
Member
|
Thank you both for addressing this. I will indeed close this one as duplicate of #723. In general, whenever there is a PR under review, a better use of resources is to help refine the respective PR, than start a new one, unless the first is abandoned (for which I would expect at least several weeks of inactivity, in most cases). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #682 (part 1)
The System tests (PR) workflow runs on any
pull_request: labeledevent. Previously,gather-refsran for every label add (making 7 GitHub API calls), whilerun-system-testsonly ran when the label wastrigger-system-tests. This wasted API quota for labels like "bug" or "GSoC".This PR gates the
gather-refsjob on the same condition asrun-system-tests:if: github.event.label.name == 'trigger-system-tests'The workflow now skips entirely for non-trigger labels, reducing GitHub API usage.
Per maintainer feedback in #723, authentication (token/App ID) is deferred and can be added separately if rate limits persist.
Checklist:
changelog-entries/682.md.