security: pin Jira attachment download to the configured Jira host#12
Draft
tuyen-at-work with Copilot wants to merge 2 commits into
Draft
security: pin Jira attachment download to the configured Jira host#12tuyen-at-work with Copilot wants to merge 2 commits into
tuyen-at-work with Copilot wants to merge 2 commits into
Conversation
Open
2 tasks
Copilot
AI
changed the title
[WIP] Fix Jira attachment download without host validation
security: pin Jira attachment download to the configured Jira host
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadJiraAttachmentssent the Jira Basic-auth header (email:PAT) toattachment.content— a URL taken verbatim from attacker-influenceable API metadata — with no host validation, allowing PAT exfiltration to an arbitrary host and SSRF against internal endpoints. GitHub and ADO providers already pin their hosts; Jira did not.Changes
provider-jira.ts: AddedassertSameJiraHost(), invoked per attachment before any auth header is sent. It rejects thecontentURL unless it parses cleanly, useshttps:, and its host matches the configuredJIRA_BASE_URLhost.provider-jira.test.ts(new): Regression tests mockingrequestJson/requestBinary— off-host and non-HTTPScontentURLs are rejected and assertrequestBinaryis never called; a valid on-host HTTPS URL is downloaded.Notes
https:in addition to host match, closing credential-over-cleartext downgrades.skills/security/SKILL.mdand the existing GitHub/ADO host-pinning pattern.