chore(release): resolve git remotes from URLs with env overrides#6116
Open
hunger wants to merge 1 commit into
Open
chore(release): resolve git remotes from URLs with env overrides#6116hunger wants to merge 1 commit into
hunger wants to merge 1 commit into
Conversation
Previously the script hard-coded 'upstream' for the canonical pull and 'origin' for the fork push, which fails on clones that name those remotes differently. Resolve them by URL instead: pick whichever remote points to prefix-dev/pixi (preferring 'upstream'), and whichever remote points to $GITHUB_USER/pixi (preferring 'origin'). $GITHUB_USER falls back to 'gh api user' when unset. $UPSTREAM_REMOTE and $FORK_REMOTE override the detection entirely for non-standard setups. The script exits with an actionable error if a remote can't be found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the script hard-coded 'upstream' for the canonical pull and 'origin' for the fork push, which fails on clones that name those remotes differently. Resolve them by URL instead: pick whichever remote points to prefix-dev/pixi (preferring 'upstream'), and whichever remote points to $GITHUB_USER/pixi (preferring 'origin'). $GITHUB_USER falls back to 'gh api user' when unset. $UPSTREAM_REMOTE and $FORK_REMOTE override the detection entirely for non-standard setups. The script exits with an actionable error if a remote can't be found.
This ports over functionality from the build backend release script.
How Has This Been Tested?
Works-for-me(TM), YOLO.
If the script fails to detect things properly: The remotes can be forced to the old, hard-coded values by setting
UPSTREAM_REMOTE=upstreamandFORK_REMOTE=originAI Disclosure
Tools: Claude
Checklist:
schema/model.py.