fix: Track Cython inputs for editable pixi-build-python builds (generated by Codex)#6123
fix: Track Cython inputs for editable pixi-build-python builds (generated by Codex)#6123kkraus14 wants to merge 1 commit into
Conversation
| }; | ||
| // Cython inputs affect compiled extension artifacts even when the | ||
| // Python package itself is installed editable. | ||
| let cython_globs = Vec::from(["**/*.{pyx,pxd,pxi}"]); |
There was a problem hiding this comment.
Also happy to just add these into the existing python_globs if you feel it's more appropriate
baszalmstra
left a comment
There was a problem hiding this comment.
Would it be possible to add these only if cython is a dependency? Tracking globs has an overhead, seems wasteful to always add these if they will not match anyway.
269a68f to
2397f6b
Compare
|
Addressed the review comment: Cython input globs are now added only when Cython is present in the model dependencies or in I also added tests for explicit model dependency, pyproject build-system dependency, and the no-Cython case. Generated by Codex. |
We were previously always tracking |
Track Cython inputs for editable pixi-build-python builds
Generated by Codex.
Summary
pixi-build-pythoninput globs.pyx,.pxd,.pxi) only when Cython is declared in the model dependencies orbuild-system.requiresFixes #6122.
Tests
Manual reproducer check:
pixi-build-pythonbackend locallyPIXI_BUILD_BACKEND_OVERRIDErepro.pyxv3tov4pixi run show-docrebuilt and printedv4pixi run show-docprintedv4without rebuild output