-
Notifications
You must be signed in to change notification settings - Fork 127
fix: hint users to enable Developer Mode on Windows symlink extraction failure #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pb01ka
wants to merge
12
commits into
prefix-dev:main
Choose a base branch
from
pb01ka:win-symlink
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
99a8744
fix(source-cache): hint users to enable Developer Mode on Windows ext…
pb01ka 303d658
test(source-cache): add symlink extraction test for Windows Developer…
pb01ka f837c6f
chore: Improvise error message
pb01ka 7fd6b43
chore(tests): run test_symlink_extraction_error_message only on Windows
pb01ka 99a124b
doc: Added code comments for is_windows_developer_mode_enabled implem…
pb01ka 59ebbe3
chore: Run pixi run -e pre-commit lint
pb01ka a5693ea
chore: Compile the helper make_tar_gz_with_symlink only on windows
pb01ka 574b8d7
chore: Run pixi run -e pre-commit lint
pb01ka 447b5bd
fix: Improve error handling and code safety
pb01ka 1878399
fix: remove is_symlink_error and always provide the hint for Develope…
pb01ka 5379768
fix: Use winreg which enables checking Developer Mode without unsafe
pb01ka 5f06024
chore: Shorten the implementation of is_windows_developer_mode_enabled
pb01ka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is also a specific io error that we are looking for? Permission denied or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reliably. The error code when symlink creation fails on Windows with Developer Mode disabled is not consistent.
ERROR_PRIVILEGE_NOT_HELD(1314) is the most common (as per my observation), but it can't reliably help in identifying a "symlink failed" error from the error alone, we instead gate the hint on the Developer Mode registry check: if Developer Mode is off and tar extraction fails for any reason, we surface the hint. The hint copy uses "may contain symbolic links" to reflect this uncertainty.