-
-
Notifications
You must be signed in to change notification settings - Fork 651
Add infoplist API + Info.plist embedding in Apple OS console apps #2733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noresources
wants to merge
8
commits into
premake:master
Choose a base branch
from
noresources:feature-infoplist
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5c32a12
Add infoplist API registration
noresources 5ac22dd
Add infoplist API support for xcode4 action
noresources 2e92335
Add toolset.getSections()
noresources 2926556
toolset.getSections() integration in codelite, gmake and ninja actions.
noresources 8f7ae83
Add documentation for infoplist API
noresources e2078d7
Add unit test for infoplist API and gcc.getSections()
noresources d250250
Remove commented code in tests
noresources 6815ae8
Fix infoplist documentation.
noresources File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1550,6 +1550,35 @@ end | |
| test.contains({ "-Wl,-rpath,'/usr/local/lib/mylibs'" }, gcc.getrunpathdirs(cfg, paths)) | ||
| end | ||
|
|
||
| -- | ||
| -- Check Info.plist embedding on Apple platforms. | ||
| -- | ||
| function suite.onMacOSXInfoPlist() | ||
| system "MacOSX" | ||
| infoplist "./MyInfo.plist" | ||
|
|
||
| prepare() | ||
|
|
||
| local actual = gcc.getSections(cfg) | ||
| local expected = "-Wl,-sectcreate,__TEXT,__info_plist,MyInfo.plist" | ||
| test.contains({expected}, actual) | ||
| end | ||
|
|
||
| function suite.notOnMacOSXInfoPlist() | ||
| system "Linux" | ||
| infoplist "./MyInfo.plist" | ||
|
|
||
| prepare() | ||
|
|
||
| local actual = gcc.getSections(cfg) | ||
| local notExpected = "-Wl,-sectcreate,__TEXT,__info_plist,MyInfo.plist" | ||
| test.excludes({notExpected}, actual) | ||
| --test.contains ("", "") | ||
| --test.contains ("", "") | ||
|
Comment on lines
+1576
to
+1577
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Commented code to remove |
||
| end | ||
|
|
||
|
|
||
|
|
||
| -- | ||
| -- Make sure unicode support is handled properly. | ||
| -- | ||
|
|
@@ -1594,4 +1623,4 @@ end | |
| characterset "Unicode" | ||
| prepare() | ||
| test.excludes({ "-municode" }, gcc.getldflags(cfg)) | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -96,6 +96,7 @@ | |||||
| | [includedirs](includedirs.md) | | | ||||||
| | [includedirsafter](includedirsafter.md) | | | ||||||
| | [includeexternal](globals/includeexternal.md) | | | ||||||
| | [infoplist](infoplist.md) | Sets the Apple ap bundle infos. | | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
? |
||||||
| | [inlining](inlining.md) | Tells the compiler when it should inline functions | | ||||||
| | [intrinsics](intrinsics.md) | | | ||||||
| | [kind](kind.md) | | | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| Sets the application bundle information file for any Apple platform application. | ||
|
|
||
| ```lua | ||
| infoplist ("path") | ||
| ``` | ||
|
|
||
| When generating Xcode action, this command will override the auto-detected Info.plist from the project file list. | ||
|
|
||
| When used in Console application projects, the Info.plist is embedded in the application binary using Apple toolchain specific linker flags. | ||
|
|
||
| ### Parameters ### | ||
|
|
||
| `path` is the file system path to the Apple property list file to use as Info.plist. | ||
|
|
||
| ### Applies To ### | ||
|
|
||
| Project configurations. | ||
|
|
||
| ### Availability ### | ||
|
|
||
| Premake 5.0 or later for Apple platform applications. | ||
|
|
||
| ### Examples ### | ||
|
|
||
| This project defines a default Info.plist and a different one for the Debug configuration. | ||
|
|
||
| ```lua | ||
| project "MyProject" | ||
|
|
||
| infoplist "Default.plist" | ||
|
|
||
| filter { "configurations:Debug" } | ||
| infoplist "DebugInfo.plist" | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% of the code is all lower case. Should we make this match?