feat: Explicitly set marker for sexy comments#546
Open
albfan wants to merge 1 commit into
Open
Conversation
Instead of extract the marker from last char of longest left comment allow to explicity set it
Closed
Author
|
to turn: into instead of using: |
Author
|
NOTE1: 'nested' is required to avoid an error: NOTE2: But that doesn't do anything using |
alerque
requested changes
Feb 13, 2026
Member
alerque
left a comment
There was a problem hiding this comment.
Resolve case where marker is not set.
|
|
||
| "if there is no hardcoded marker then we find one | ||
| if sexyComMarker ==# '' | ||
| if b:NERDSexyComMarkerSet == 0 && sexyComMarker ==# '' |
Member
There was a problem hiding this comment.
It doesn't look like this buffer value is getting set unconditionally, so this will error in the event it is not set ... no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of extract the marker from last char of longest left comment allow to explicity set it
relates with #329