feat(plugin-iceberg): Add support for ALTER COLUMN SET DATA TYPE in the Iceberg connector (#25418)

Add support for ALTER COLUMN SET DATA TYPE in the Iceberg connector

To address the issue : #25417

<!---Describe any public API or user-facing feature change or any
performance impact-->

<!---Please fill in how you tested your change-->

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.

Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== RELEASE NOTES ==

General Changes
* Add support for ALTER COLUMN SET DATA TYPE in the Iceberg connector

Co-authored-by: Dong Wang <mingwbd@gmail.com>

Author: 2 people

presto-analyzer/src/main/java/com/facebook/presto/sql/analyzer/utils/StatementUtils.java

@@ -62,6 +62,7 @@
 import com.facebook.presto.sql.tree.Revoke;
 import com.facebook.presto.sql.tree.RevokeRoles;
 import com.facebook.presto.sql.tree.Rollback;
+import com.facebook.presto.sql.tree.SetColumnType;
 import com.facebook.presto.sql.tree.SetProperties;
 import com.facebook.presto.sql.tree.SetRole;
 import com.facebook.presto.sql.tree.SetSession;
@@ -172,6 +173,7 @@ private StatementUtils() {}
         builder.put(Revoke.class, QueryType.DATA_DEFINITION);
         builder.put(Prepare.class, QueryType.CONTROL);
         builder.put(Deallocate.class, QueryType.CONTROL);
+        builder.put(SetColumnType.class, QueryType.DATA_DEFINITION);
 
         STATEMENT_QUERY_TYPES = builder.build();
     }

presto-blackhole/src/main/java/com/facebook/presto/plugin/blackhole/BlackHoleMetadata.java

@@ -14,6 +14,7 @@
 package com.facebook.presto.plugin.blackhole;
 
 import com.facebook.airlift.units.Duration;
+import com.facebook.presto.common.type.Type;
 import com.facebook.presto.spi.ColumnHandle;
 import com.facebook.presto.spi.ColumnMetadata;
 import com.facebook.presto.spi.ConnectorInsertTableHandle;
@@ -286,4 +287,23 @@ private void checkSchemaExists(String schemaName)
             throw new SchemaNotFoundException(schemaName);
         }
     }
+
+    @Override
+    public void setColumnType(ConnectorSession session, ConnectorTableHandle tableHandle, ColumnHandle columnHandle, Type type)
+    {
+        BlackHoleTableHandle table = (BlackHoleTableHandle) tableHandle;
+        BlackHoleColumnHandle column = (BlackHoleColumnHandle) columnHandle;
+        List<BlackHoleColumnHandle> columns = new ArrayList<>(table.getColumnHandles());
+        columns.set(columns.indexOf(column), new BlackHoleColumnHandle(column.getName(), type));
+
+        tables.put(table.toSchemaTableName(), new BlackHoleTableHandle(
+                table.getSchemaName(),
+                table.getTableName(),
+                ImmutableList.copyOf(columns),
+                table.getSplitCount(),
+                table.getPagesPerSplit(),
+                table.getRowsPerPage(),
+                table.getFieldsLength(),
+                table.getPageProcessingDelay()));
+    }
 }

presto-common/src/main/java/com/facebook/presto/common/type/DoubleType.java

@@ -16,6 +16,7 @@
 import com.facebook.presto.common.block.Block;
 import com.facebook.presto.common.block.BlockBuilder;
 import com.facebook.presto.common.block.BlockBuilderStatus;
+import com.facebook.presto.common.block.IntArrayBlock;
 import com.facebook.presto.common.block.LongArrayBlockBuilder;
 import com.facebook.presto.common.block.PageBuilderStatus;
 import com.facebook.presto.common.block.UncheckedBlock;
@@ -27,6 +28,7 @@
 import static com.facebook.presto.common.type.TypeUtils.doubleHashCode;
 import static java.lang.Double.doubleToLongBits;
 import static java.lang.Double.longBitsToDouble;
+import static java.lang.Float.intBitsToFloat;
 
 public final class DoubleType
         extends AbstractPrimitiveType
@@ -67,6 +69,9 @@ public Object getObjectValue(SqlFunctionProperties properties, Block block, int
         if (block.isNull(position)) {
             return null;
         }
+        if (IntArrayBlock.class.isInstance(block)) {
+            return intBitsToFloat(block.getInt(position));
+        }
         return longBitsToDouble(block.getLong(position));
     }
 
@@ -109,13 +114,22 @@ public void appendTo(Block block, int position, BlockBuilder blockBuilder)
             blockBuilder.appendNull();
         }
         else {
-            blockBuilder.writeLong(block.getLong(position)).closeEntry();
+            if (block instanceof IntArrayBlock) {
+                float flt = intBitsToFloat(block.getInt(position));
+                blockBuilder.writeLong(doubleToLongBits(flt)).closeEntry();
+            }
+            else {
+                blockBuilder.writeLong(block.getLong(position)).closeEntry();
+            }
         }
     }
 
     @Override
     public double getDouble(Block block, int position)
     {
+        if (block instanceof IntArrayBlock) {
+            return intBitsToFloat(block.getInt(position));
+        }
         return longBitsToDouble(block.getLong(position));
     }
 

presto-common/src/main/java/com/facebook/presto/common/type/LongDecimalType.java

@@ -17,19 +17,23 @@
 import com.facebook.presto.common.block.BlockBuilder;
 import com.facebook.presto.common.block.BlockBuilderStatus;
 import com.facebook.presto.common.block.Int128ArrayBlockBuilder;
+import com.facebook.presto.common.block.LongArrayBlock;
 import com.facebook.presto.common.block.PageBuilderStatus;
 import com.facebook.presto.common.function.SqlFunctionProperties;
 import io.airlift.slice.Slice;
 import io.airlift.slice.Slices;
 
+import java.math.BigInteger;
+
 import static com.facebook.presto.common.block.Int128ArrayBlock.INT128_BYTES;
 import static com.facebook.presto.common.type.Decimals.MAX_PRECISION;
 import static com.facebook.presto.common.type.Decimals.decodeUnscaledValue;
+import static com.facebook.presto.common.type.Decimals.encodeUnscaledValue;
 import static com.facebook.presto.common.type.UnscaledDecimal128Arithmetic.UNSCALED_DECIMAL_128_SLICE_LENGTH;
 import static com.facebook.presto.common.type.UnscaledDecimal128Arithmetic.compare;
 import static io.airlift.slice.SizeOf.SIZE_OF_LONG;
 
-final class LongDecimalType
+public final class LongDecimalType
         extends DecimalType
 {
     LongDecimalType(int precision, int scale)
@@ -77,6 +81,10 @@ public Object getObjectValue(SqlFunctionProperties properties, Block block, int
         if (block.isNull(position)) {
             return null;
         }
+        if (block instanceof LongArrayBlock) {
+            long unscaledValue = block.getLong(position);
+            return new SqlDecimal(BigInteger.valueOf(unscaledValue), getPrecision(), getScale());
+        }
         Slice slice = getSlice(block, position);
         return new SqlDecimal(decodeUnscaledValue(slice), getPrecision(), getScale());
     }
@@ -112,9 +120,15 @@ public void appendTo(Block block, int position, BlockBuilder blockBuilder)
             blockBuilder.appendNull();
         }
         else {
-            blockBuilder.writeLong(block.getLong(position, 0));
-            blockBuilder.writeLong(block.getLong(position, SIZE_OF_LONG));
-            blockBuilder.closeEntry();
+            if (block instanceof LongArrayBlock) {
+                Slice slice = encodeUnscaledValue(block.getLong(position));
+                writeSlice(blockBuilder, slice);
+            }
+            else {
+                blockBuilder.writeLong(block.getLong(position, 0));
+                blockBuilder.writeLong(block.getLong(position, SIZE_OF_LONG));
+                blockBuilder.closeEntry();
+            }
         }
     }
 
@@ -138,6 +152,9 @@ public void writeSlice(BlockBuilder blockBuilder, Slice value, int offset, int l
     @Override
     public Slice getSlice(Block block, int position)
     {
+        if (block instanceof LongArrayBlock) {
+            return encodeUnscaledValue(block.getLong(position));
+        }
         return Slices.wrappedLongArray(
                 block.getLong(position, 0),
                 block.getLong(position, SIZE_OF_LONG));

presto-docs/src/main/sphinx/sql/alter-table.rst

@@ -17,6 +17,7 @@ Synopsis
     ALTER TABLE [ IF EXISTS ] name SET PROPERTIES (property_name=value, [, ...])
     ALTER TABLE [ IF EXISTS ] name DROP BRANCH [ IF EXISTS ] branch_name
     ALTER TABLE [ IF EXISTS ] name DROP TAG [ IF EXISTS ] tag_name
+    ALTER TABLE [ IF EXISTS ] name ALTER COLUMN column_name SET DATA TYPE new_type
     ALTER TABLE [ IF EXISTS ] name CREATE [ OR REPLACE ] BRANCH [ IF NOT EXISTS ] branch_name
     ALTER TABLE [ IF EXISTS ] name CREATE [ OR REPLACE ] BRANCH [ IF NOT EXISTS ] branch_name FOR SYSTEM_VERSION AS OF version
     ALTER TABLE [ IF EXISTS ] name CREATE [ OR REPLACE ] BRANCH [ IF NOT EXISTS ] branch_name FOR SYSTEM_TIME AS OF timestamp

presto-hive/src/main/java/com/facebook/presto/hive/security/LegacyAccessControl.java

@@ -241,6 +241,9 @@ public void checkCanCreateViewWithSelectFromColumns(ConnectorTransactionHandle t
     {
     }
 
+    @Override
+    public void checkCanAlterColumn(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) {}
+
     @Override
     public void checkCanSetCatalogSessionProperty(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, String propertyName)
     {

presto-hive/src/main/java/com/facebook/presto/hive/security/SqlStandardAccessControl.java

@@ -56,6 +56,7 @@
 import static com.facebook.presto.hive.metastore.thrift.ThriftMetastoreUtil.listEnabledTablePrivileges;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyAddColumn;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyAddConstraint;
+import static com.facebook.presto.spi.security.AccessDeniedException.denyAlterColumn;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyCallProcedure;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyCreateBranch;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyCreateRole;
@@ -405,6 +406,24 @@ public void checkCanUpdateTableColumns(ConnectorTransactionHandle transaction, C
         }
     }
 
+    @Override
+    public void checkCanAlterColumn(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName)
+    {
+        MetastoreContext metastoreContext = new MetastoreContext(
+                identity, context.getQueryId().getId(),
+                context.getClientInfo(),
+                context.getClientTags(),
+                context.getSource(),
+                Optional.empty(),
+                false,
+                HiveColumnConverterProvider.DEFAULT_COLUMN_CONVERTER_PROVIDER,
+                context.getWarningCollector(),
+                context.getRuntimeStats());
+        if (!isTableOwner(transaction, identity, metastoreContext, tableName)) {
+            denyAlterColumn(tableName.toString());
+        }
+    }
+
     @Override
     public void checkCanCreateView(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName viewName)
     {

presto-iceberg/pom.xml

@@ -784,6 +784,10 @@
             <artifactId>commons-math3</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>com.facebook.presto</groupId>
+            <artifactId>presto-parser</artifactId>
+        </dependency>
     </dependencies>
 
     <build>