Skip to content

Use location information from {Typeof,Void}Expression #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fisker merged 1 commit into from
Jan 8, 2026
Merged

Use location information from {Typeof,Void}Expression #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 26 additions & 41 deletions src/transform-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,54 +275,39 @@ class Transformer extends Source {
});
}

if (
node instanceof angular.PrefixNot ||
node instanceof angular.TypeofExpression ||
node instanceof angular.VoidExpression
) {
const operator =
node instanceof angular.PrefixNot
? '!'
: node instanceof angular.TypeofExpression
? 'typeof'
: node instanceof angular.VoidExpression
? 'void'
: /* c8 ignore next @preserve */
undefined;

/* c8 ignore next 3 @preserve */
if (!operator) {
throw new Error('Unexpected expression.');
}

let { start } = node.sourceSpan;

// https://github.com/angular/angular/issues/66174
if (operator === 'typeof' || operator === 'void') {
const index = this.text.lastIndexOf(operator, start);

/* c8 ignore next 7 @preserve */
if (index === -1) {
throw new Error(
`Cannot find operator '${operator}' from index ${start} in ${JSON.stringify(
this.text,
)}`,
);
}

start = index;
}
if (node instanceof angular.PrefixNot) {
return createNode<babel.UnaryExpression>(
{
type: 'UnaryExpression',
prefix: true,
operator: '!',
argument: transformChild<babel.Expression>(node.expression),
},
node.sourceSpan,
);
}

const expression = transformChild<babel.Expression>(node.expression);
if (node instanceof angular.TypeofExpression) {
return createNode<babel.UnaryExpression>(
{
type: 'UnaryExpression',
prefix: true,
operator: 'typeof',
argument: transformChild<babel.Expression>(node.expression),
},
node.sourceSpan,
);
}

if (node instanceof angular.VoidExpression) {
return createNode<babel.UnaryExpression>(
{
type: 'UnaryExpression',
prefix: true,
operator,
argument: expression,
operator: 'void',
argument: transformChild<babel.Expression>(node.expression),
},
[start, node.sourceSpan.end],
node.sourceSpan,
);
}

Expand Down