fix: handle assignref in needsParens like assign

assignref was missing from the needsParens switch, falling through
to return false. This caused parens to be dropped in contexts where
they change semantics, e.g. $a = ($b =& $var) + 5 became
$a = $b = &$var + 5.

Author: jorgsowa

src/needs-parens.mjs

@@ -158,15 +158,16 @@ function needsParens(path, options) {
           return !!(node.key || node.value);
       }
     }
+    case "assignref":
     case "assign": {
       if (
         parent.kind === "for" &&
         (parent.init.includes(node) || parent.increment.includes(node))
       ) {
         return false;
-      } else if (parent.kind === "assign") {
+      } else if (parent.kind === "assign" || parent.kind === "assignref") {
         return false;
-      } else if (parent.kind === "static") {
+      } else if (parent.kind === "staticvariable") {
         return false;
       } else if (
         ["if", "do", "while", "foreach", "switch"].includes(parent.kind)

tests/assignref/__snapshots__/jsfmt.spec.mjs.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`assignref.php 1`] = `
 ====================================options=====================================
@@ -42,6 +42,7 @@ $cached_var = &drupal_static(__FUNCTION__);
 
 $test = ['key' => &$value];
 $test = ['key' => &$value['something']];
+$x = $y =& $z;
 
 =====================================output=====================================
 <?php
@@ -56,7 +57,7 @@ class Foo
     }
 }
 
-$a = &$b / 100;
+($a = &$b) / 100;
 
 $var =
     $arr[
@@ -96,6 +97,7 @@ $cached_var = &drupal_static(__FUNCTION__);
 
 $test = ["key" => &$value];
 $test = ["key" => &$value["something"]];
+$x = $y = &$z;
 
 ================================================================================
 `;

tests/assignref/assignref.php

@@ -34,3 +34,4 @@ public function test() {
 
 $test = ['key' => &$value];
 $test = ['key' => &$value['something']];
+$x = $y =& $z;

tests/parens/__snapshots__/jsfmt.spec.mjs.snap

@@ -672,14 +672,14 @@ $test = $var = &$test;
 $test = $var = &$test;
 
 $a = ($b = $var) + 5;
-$a = $b = &$var + 5;
+$a = ($b = &$var) + 5;
 
 $a = ($b = $var) || 5;
-$a = $b = &$var || 5;
+$a = ($b = &$var) || 5;
 
-if ($foo = &$bar && count($foo) > 0) {
+if (($foo = &$bar) && count($foo) > 0) {
 }
-if ($foo = &test1() && test2($foo) > 0) {
+if (($foo = &test1()) && test2($foo) > 0) {
 }
 
 call($a = &$b);
@@ -720,14 +720,14 @@ $test = $var = &$test;
 $test = $var = &$test;
 
 $a = ($b = $var) + 5;
-$a = $b = &$var + 5;
+$a = ($b = &$var) + 5;
 
 $a = ($b = $var) || 5;
-$a = $b = &$var || 5;
+$a = ($b = &$var) || 5;
 
-if ($foo = &$bar && count($foo) > 0) {
+if (($foo = &$bar) && count($foo) > 0) {
 }
-if ($foo = &test1() && test2($foo) > 0) {
+if (($foo = &test1()) && test2($foo) > 0) {
 }
 
 call($a = &$b);