feat: correctly parse and format 8.4 syntax

Author: claytonrcarter

src/parser.mjs

@@ -10,11 +10,16 @@ function parse(text, opts) {
   // Todo https://github.com/glayzzle/php-parser/issues/170
   text = text.replace(/\?>\n<\?/g, "?>\n___PSEUDO_INLINE_PLACEHOLDER___<?");
 
+  const parserOpts = Object.assign(
+    { extractDoc: true },
+    // only pass the version if user requested 8.4 syntax; parser is stricter
+    // about allowed syntax than we are and currenly defaults to support for 8.3
+    opts && opts.phpVersion === "8.4" ? { version: opts.phpVersion } : {}
+  );
+
   // initialize a new parser instance
   const parser = new engine({
-    parser: {
-      extractDoc: true,
-    },
+    parser: parserOpts,
     ast: {
       withPositions: true,
       withSource: true,

src/printer.mjs

@@ -774,11 +774,12 @@ function printBinaryExpression(
       parts.push(print("left"));
     }
 
-    const shouldInline = shouldInlineLogicalExpression(node);
-
-    const right = shouldInline
-      ? [node.type, " ", print("right")]
-      : [node.type, line, print("right")];
+    const right =
+      node.left.kind === "new" && node.type !== "."
+        ? [node.type, print("right")]
+        : shouldInlineLogicalExpression(node)
+          ? [node.type, " ", print("right")]
+          : [node.type, line, print("right")];
 
     // If there's only a single binary expression, we want to create a group
     // in order to avoid having a small right part like -1 be on its own line.
@@ -794,6 +795,7 @@ function printBinaryExpression(
 
     const shouldNotHaveWhitespace =
       isDocNode(node.left) ||
+      (node.left.kind === "new" && node.type !== ".") ||
       (node.left.kind === "bin" && isDocNode(node.left.right));
 
     parts.push(

tests/new84/__snapshots__/jsfmt.spec.mjs.snap

@@ -0,0 +1,24 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`new84.php 1`] = `
+====================================options=====================================
+parsers: ["php"]
+phpVersion: "8.4"
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+<?php
+
+new Foo->prop;
+new Foo->method();
+new Foo->$var;
+
+=====================================output=====================================
+<?php
+
+new Foo()->prop;
+new Foo()->method();
+new Foo()->$var;
+
+================================================================================
+`;

tests/new84/jsfmt.spec.mjs

@@ -0,0 +1 @@
+run_spec(import.meta, ["php"], { phpVersion: "8.4" });

tests/new84/new84.php

@@ -0,0 +1,5 @@
+<?php
+
+new Foo->prop;
+new Foo->method();
+new Foo->$var;