Skip to content

Testing content#86

Open
nickserv wants to merge 20 commits into
mainfrom
testing-content
Open

Testing content#86
nickserv wants to merge 20 commits into
mainfrom
testing-content

Conversation

@nickserv

@nickserv nickserv commented Nov 7, 2019

Copy link
Copy Markdown
Member

#53

  • Test basic button injection
  • Create fully-functioning stubs
    • chrome.extension.storage.sync
    • MutationObserver
  • Attempt to test with mocked window.location
  • Test option loading behavior
  • Consider adding more granular unit tests per class/file/method/function
  • Consider using dom-testing-library for better assertions and consistency with Testing options #87
  • Complete test coverage

Comment thread .eslintrc.json Outdated
@kaicataldo

Copy link
Copy Markdown
Member

Can we fix the merge conflicts and merge this? If everything is set up, I don't think we need to wait until we have complete coverage before merging.

@kaicataldo

This comment has been minimized.

@nickserv
nickserv marked this pull request as ready for review August 29, 2020 23:09
@nickserv

nickserv commented Aug 30, 2020

Copy link
Copy Markdown
Member Author

I'm going to see if I can swap in sinon-chrome similarly to #87 before I merge this. Maintaining mocks manually is a lot of churn.

Base automatically changed from master to main February 1, 2021 03:57
@kaicataldo

Copy link
Copy Markdown
Member

Are you still working on this? If not, I think it would be best to close the PR for now so others can feel free to work on it (would love to land this PR if you're still working on it, though!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants