Skip to content

Testing options#87

Draft
nickserv wants to merge 18 commits into
mainfrom
testing-options
Draft

Testing options#87
nickserv wants to merge 18 commits into
mainfrom
testing-options

Conversation

@nickserv

@nickserv nickserv commented Nov 7, 2019

Copy link
Copy Markdown
Member

#53

  • Create fully-functioning chrome.extension.storage.sync stub Use sinon-chrome with webextension-polyfill
  • Test option syncing behavior

@nickserv nickserv mentioned this pull request Nov 7, 2019
9 tasks
@kaicataldo

Copy link
Copy Markdown
Member

What's the status on this?

@nickserv

Copy link
Copy Markdown
Member Author

I've fixed merge conflicts and several configuration issues. Now that we're using sinon-chrome we no longer need to develop complex mocks and can just focus on implementing the options tests (mainly interested in syncing behavior).

Base automatically changed from master to main February 1, 2021 03:57
@kaicataldo

Copy link
Copy Markdown
Member

Are you still working on this? If not, I think it would be best to close the PR for now so others can feel free to work on it (would love to land this PR if you're still working on it, though!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants