Conversation
Member
Author
|
Blocked by fabiospampinato/tiny-readdir-glob#5 |
fabiospampinato
force-pushed
the
main
branch
4 times, most recently
from
34e0257 to
f8dc396
Compare
Collaborator
|
It may be good to split this into two, one that enables CI for windows and linux and another that fixes the problem found by that. |
Contributor
|
The fix for fabiospampinato/tiny-readdir-glob#5 has been released in 1.23.2. |
Collaborator
|
If possible I'd split this into 2 PRs, one that sets up CI and one that fixes the issues for Windows |
Member
Author
|
I don't understand why but here it is #56 |
Collaborator
|
It seemed cleaner, maybe also one see the the failing tests this way. Can you rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47