fix: strip ANSI escape codes from error messages in output channel#4005
Open
sijie-Z wants to merge 1 commit into
Open
fix: strip ANSI escape codes from error messages in output channel#4005sijie-Z wants to merge 1 commit into
sijie-Z wants to merge 1 commit into
Conversation
Prettier v12.x started outputting ANSI color codes in error messages. The VS Code Output panel does not interpret ANSI escape sequences, causing raw codes like [31m[1m to clutter the output. Strip ANSI codes before writing to the output channel so error messages remain readable. Applied to LoggingService.logError() and logMessage(). Closes prettier#4002
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since Prettier v12.x, error messages can contain ANSI color codes. The VS Code Output panel does not interpret ANSI
escape sequences, causing raw codes like
[31m[1mto clutter the output and make errors unreadable.Solution
Strip ANSI escape codes before writing messages to the output channel. Applied in
LoggingService.logError()andlogMessage()so all log levels are covered.Related Issue
Closes #4002
Type of Change
Checklist
npm run prettierpasses)npm run prettierto format my code