[Chore] 헤더 nav바 정리 및 로그인 회원가입 페이지 깨진 디자인 수정 #17
Merged
Conversation
jean2077
force-pushed
the
chore/1-header-nav-auth-ui-fix
branch
from
e85416e to
14c21a2
Compare
slyhyun
approved these changes
May 28, 2026
Collaborator
slyhyun
left a comment
slyhyun
left a comment
There was a problem hiding this comment.
SignupPage.tsx:891 쪽 회원가입 버튼 노출 조건이 isGithubConnected만 보고 있어서, GitHub 연동 후 약관 체크를 다시 해제해도 버튼은 남아 있습니다. 제출 시 handleSubmit에서 막히긴 해서 치명적이진 않은 것 같습니다.
lgtm👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔎 What
🔗 Issue
✅ 체크리스트