feat: 피드 수정/삭제시 참조를 잃은 태그 또한 삭제

Author: dlsrks1021

NBE_5_7_2_02TEAM/src/main/java/io/twogether/nbe_5_7_2_02team/post/dao/PostTagRepository.java

@@ -4,6 +4,7 @@
 import io.twogether.nbe_5_7_2_02team.post.domain.PostTag;
 
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Query;
 
 import java.util.List;
 
@@ -12,4 +13,7 @@ public interface PostTagRepository extends JpaRepository<PostTag, Long> {
     void deleteAllByPost(Post post);
 
     List<PostTag> findAllByPost(Post post);
-}
+
+    @Query("SELECT DISTINCT pt.tag.id FROM PostTag pt")
+    List<Long> findAllTagIds();
+}

NBE_5_7_2_02TEAM/src/main/java/io/twogether/nbe_5_7_2_02team/post/service/PostService.java

@@ -25,6 +25,7 @@
 import io.twogether.nbe_5_7_2_02team.post.util.ImageUploader;
 import io.twogether.nbe_5_7_2_02team.post.util.PostMapper;
 
+import io.twogether.nbe_5_7_2_02team.tag.dao.TagRepository;
 import lombok.RequiredArgsConstructor;
 
 import org.springframework.security.core.userdetails.UserDetails;
@@ -46,6 +47,7 @@ public class PostService {
     private final ImageUploader imageUploader;
     private final ChatRepository chatRepository;
     private final LikesRepository likesRepository;
+    private final TagRepository tagRepository;
 
     @Transactional
     public PostResponse createPost(PostCreateRequest request, Long memberId) {
@@ -96,6 +98,7 @@ public PostResponse updatePost(Long postId, PostUpdateRequest request, Long memb
 
         if (request.getTags() != null) {
             postTagRepository.deleteAllByPost(updatePost);
+            deleteUnusedTags();
 
             List<PostTag> newTags = postMapper.toPostTags(updatePost, request.getTags());
             postTagRepository.saveAll(newTags);
@@ -119,6 +122,12 @@ public void deletePost(Long postId, Long memberId) {
         chatRepository.deleteByPost(deletePost);
         imageUploader.deletePostImageByFolder(deletePost.getId());
         postRepository.delete(deletePost);
+        deleteUnusedTags();
+    }
+
+    private void deleteUnusedTags() {
+        List<Long> referredTagIds = postTagRepository.findAllTagIds();
+        tagRepository.deleteUnusedTags(referredTagIds);
     }
 
     @Transactional(readOnly = true)

NBE_5_7_2_02TEAM/src/main/java/io/twogether/nbe_5_7_2_02team/tag/dao/TagRepository.java

@@ -2,11 +2,23 @@
 
 import io.twogether.nbe_5_7_2_02team.tag.domain.Tag;
 
+import java.util.List;
 import org.springframework.data.jpa.repository.JpaRepository;
 
 import java.util.Optional;
+import org.springframework.data.jpa.repository.Modifying;
+import org.springframework.data.jpa.repository.Query;
 
 public interface TagRepository extends JpaRepository<Tag, Long> {
 
     Optional<Tag> findByName(String name);
+
+    @Query(
+        """
+        DELETE FROM Tag t
+                WHERE t.id NOT IN :referredTagIds
+        """
+    )
+    @Modifying
+    void deleteUnusedTags(List<Long> referredTagIds);
 }

NBE_5_7_2_02TEAM/src/test/java/io/twogether/nbe_5_7_2_02team/browser/PostBrowserSuccessTest.java

@@ -4,7 +4,9 @@
 import static io.twogether.nbe_5_7_2_02team.post.domain.RecruitmentStatus.NONE;
 import static io.twogether.nbe_5_7_2_02team.post.domain.RecruitmentStatus.RECRUITING;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.multipart;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
@@ -17,8 +19,10 @@
 import io.twogether.nbe_5_7_2_02team.member.dao.MemberRepository;
 import io.twogether.nbe_5_7_2_02team.member.domain.Member;
 import io.twogether.nbe_5_7_2_02team.oauth.dto.common.TokenPair;
+import io.twogether.nbe_5_7_2_02team.post.dao.PostRepository;
 import io.twogether.nbe_5_7_2_02team.post.domain.RecruitmentStatus;
 
+import io.twogether.nbe_5_7_2_02team.tag.dao.TagRepository;
 import lombok.AllArgsConstructor;
 
 import org.junit.jupiter.api.DisplayName;
@@ -35,6 +39,10 @@
 public class PostBrowserSuccessTest extends BrowserTestTemplate {
 
     @Autowired MemberRepository memberRepository;
+    @Autowired
+    private TagRepository tagRepository;
+    @Autowired
+    private PostRepository postRepository;
 
     @AllArgsConstructor
     static class PostCreateRequest {
@@ -234,6 +242,35 @@ void getPostsPaging() throws Exception {
                         jsonPath("$.posts[0].post_id").value(1));
     }
 
+    @Test
+    @DataSet(
+        value = {
+            "datasets/v2/member.yml",
+            "datasets/v2/post.yml",
+            "datasets/v2/tag.yml",
+        },
+        cleanBefore = true,
+        cleanAfter = true)
+    @DisplayName("DELETE: /api/posts/{postId} 회원 접근 - 게시글 삭제 시 연관 게시글이 없는 태그 또한 삭제")
+    void deletePostWithUnusedTags() throws Exception {
+        // given
+        long targetMemberId = 1L;
+        long targetPostId = 2L;
+        TokenPair tokenPair = getTokenPair(targetMemberId);
+
+        // when
+        mockMvc.perform(
+            delete("/api/posts/" + targetPostId)
+                .header("Authorization", "Bearer " + tokenPair.getAccessToken())
+        ).andExpect(
+            status().isOk()
+        );
+
+        // then : 2번 게시글 삭제 시 2번 태그는 참조를 잃어 삭제되어야 함
+        assertThat(postRepository.findById(targetPostId).isPresent()).isFalse();
+        assertThat(tagRepository.findById(2L).isPresent()).isFalse();
+    }
+
     private TokenPair getTokenPair(Long memberId) {
         Member member = memberRepository.findById(memberId).orElseThrow();
         return jwtTokenProvider.generateTokenPair(member);