[Feature] 사용자 위치별 미세먼지 조회 기능 구현#252
Open
limseohyeon wants to merge 12 commits into
Hidden character warning
The head ref may contain hidden characters: "feature/#235-\uc0ac\uc6a9\uc790-\uc704\uce58\ubcc4-\ubbf8\uc138\uba3c\uc9c0"
Open
Conversation
1 task
Test Results 81 files 81 suites 4m 52s ⏱️ Results for commit 4f5b6fb. ♻️ This comment has been updated with latest results. |
Collaborator
ObservatoryResponse observatoryResponse = getObservatory(lat, lng);
if (isSeoul(observatoryResponse)) {
return getCachedAirQuality("seoul").orElseGet(this::updateAriQuality);
}Provider에서 보면 getObservatory 가 null 값도 반환할 수 있던데 그럴 가능성은 없나요? 만약 null 이 넘어오게 된다면 |
Dongjin0224
approved these changes
May 12, 2025
Collaborator
Author
헉 그러네요! 말씀해주신 부분 확인하고 Optional로 처리한 후 널포인터 발생하지 않도록 수정했습니다. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



#️⃣ 연관된 이슈
✅ 체크리스트
📝 작업 내용
사용자 위치 좌표 기준으로 제일 가까운 관측소 조회
📸 스크린샷 (UI 변경 시 필수)
👀 리뷰어 가이드라인
현재 Service에 많은 역할이 할당 되어 있어 추후 리팩터링을 거칠 예정입니다.