Skip to content

[Refactor] AWS S3 업로드 코드 테스트 시 Mocking #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DongminL merged 3 commits into from
Jan 6, 2026
Merged

[Refactor] AWS S3 업로드 코드 테스트 시 Mocking #290

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
294ac7a
refactor: AWS S3 업로드 부분 Mocking
DongminL Jan 5, 2026
2afe00e
refactor: 사용하지 않는 변수 제거
DongminL Jan 5, 2026
40d1f73
refactor: protected 접근제한자 제거
DongminL Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/test/java/org/programmers/signalbuddyfinal/domain/postit/service/PostItServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
package org.programmers.signalbuddyfinal.domain.postit.service;


import static org.assertj.core.api.Assertions.*;
import static org.junit.jupiter.api.Assertions.*;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

import java.net.URL;
import java.time.LocalDateTime;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.locationtech.jts.geom.Point;
import org.programmers.signalbuddyfinal.global.util.PointUtils;
import org.programmers.signalbuddyfinal.domain.member.entity.Member;
import org.programmers.signalbuddyfinal.domain.member.entity.enums.MemberRole;
import org.programmers.signalbuddyfinal.domain.member.entity.enums.MemberStatus;
Expand All @@ -24,9 +28,12 @@
import org.programmers.signalbuddyfinal.global.dto.CustomUser2Member;
import org.programmers.signalbuddyfinal.global.exception.BusinessException;
import org.programmers.signalbuddyfinal.global.security.basic.CustomUserDetails;
import org.programmers.signalbuddyfinal.global.service.AwsFileService;
import org.programmers.signalbuddyfinal.global.support.IntegrationTest;
import org.programmers.signalbuddyfinal.global.util.PointUtils;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.mock.web.MockMultipartFile;
import org.springframework.test.context.bean.override.mockito.MockitoBean;

class PostItServiceTest extends IntegrationTest {

Expand All @@ -38,19 +45,19 @@ class PostItServiceTest extends IntegrationTest {
private MemberRepository memberRepository;
@Autowired
private PostitSolveRepository postitSolveRepository;
@MockitoBean
private AwsFileService awsFileService;

private Member member1;
private Member member2;
private CustomUser2Member user1;
private CustomUser2Member user2;
private CustomUser2Member notUser;
MockMultipartFile mockImage1;
MockMultipartFile mockImage2;

@BeforeEach
protected void setUp() throws Exception {
void setUp() {
member1 = createMember("user1@gmail.com", "user1");
member2 = createMember("user2@gmail.com", "user2");

mockImage1 = new MockMultipartFile(
"image",
Expand Down Expand Up @@ -82,6 +89,10 @@ void createPostItSuccessTest() {
PostItCreateRequest request = createPostItCreateRequest("제목", "내용",
LocalDateTime.of(25, 1, 1, 0, 0));

when(awsFileService.uploadFileToS3(any(MockMultipartFile.class), anyString()))
.thenReturn(mockImage2.getName());
when(awsFileService.getFileFromS3(anyString(), anyString()))
.thenReturn(mock(URL.class));
PostItResponse response = postItService.createPostIt(request, mockImage1, user1);

assertThat(response.getContent()).isEqualTo(request.getContent());
Expand All @@ -108,6 +119,10 @@ void updatePostItTest() {
"제목1", "img1", LocalDateTime.of(2025, 1, 1, 0, 0), member1));
PostItRequest request = createPostItRequest("제목", "내용");

when(awsFileService.uploadFileToS3(any(MockMultipartFile.class), anyString()))
.thenReturn(mockImage2.getName());
when(awsFileService.getFileFromS3(anyString(), anyString()))
.thenReturn(mock(URL.class));
PostItResponse response = postItService.updatePostIt(1L, request, mockImage2, user1);

assertThat(response.getContent()).isEqualTo(request.getContent());
Expand Down Expand Up @@ -146,7 +161,6 @@ void otherUserDeletePostItTest() {
postItRepository.save(
createPostIt(Danger.NOTICE, PointUtils.toPoint(1.0203, 1.3048), "제목1",
"제목1", "img1", LocalDateTime.of(2025, 1, 1, 0, 0), member1));
PostItRequest request = createPostItRequest("제목", "내용");

assertThrows(BusinessException.class,
() -> postItService.deletePostIt(1L, user2));
Expand Down