Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void admitUsers() {

private void processAdmissionForLesson(Long lessonId) {
// 해당 레슨 대기열에서 인원 추출
Set<String> requestIds = waitingRoomService.dequeue(lessonId, ADMIT_BATCH_SIZE);
List<String> requestIds = waitingRoomService.dequeue(lessonId, ADMIT_BATCH_SIZE);

if (requestIds.isEmpty()) {
return;
Expand All @@ -69,7 +69,7 @@ private void processAdmissionForLesson(Long lessonId) {
if (parts.length < 3)
continue;

String requestId = requestIds.toArray(new String[0])[i];
String requestId = requestIds.get(i);
Long userId = Long.parseLong(parts[2]);
Long originalTimestamp = parts.length >= 4 ? Long.parseLong(parts[3]) : System.currentTimeMillis();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.atomic.AtomicInteger;

import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.context.annotation.Profile;
Expand Down Expand Up @@ -56,7 +57,7 @@ private void processAdmissionForLesson(Long lessonId) {
}

// 해당 레슨 대기열에서 인원 추출
Set<String> requestIds = waitingRoomService.dequeue(lessonId, ADMIT_BATCH_SIZE);
List<String> requestIds = waitingRoomService.dequeue(lessonId, ADMIT_BATCH_SIZE);

if (requestIds.isEmpty()) {
return;
Expand All @@ -68,22 +69,44 @@ private void processAdmissionForLesson(Long lessonId) {
.toList();
List<String> statusInfos = mqRedisTemplate.opsForValue().multiGet(statusKeys);

if (statusInfos == null) return;
if (statusInfos == null) {
log.warn(
"Admission diagnostics. lessonId={}, dequeuedCount={}, statusKeyCount={}, statusInfos=null. Admission skipped after dequeue.",
lessonId, requestIds.size(), statusKeys.size());
return;
}

AtomicInteger statusNullCount = new AtomicInteger();
AtomicInteger invalidStatusCount = new AtomicInteger();
AtomicInteger xaddAttemptCount = new AtomicInteger();

// Pipelining 방식으로 요청 상태 변경 / Stream ADD 로직 일괄 처리
mqRedisTemplate.executePipelined(new SessionCallback<Object>() {
@Override
public Object execute(RedisOperations operations) {
for (int i = 0; i < statusKeys.size(); i++) {
String info = statusInfos.get(i);
if (info == null) continue;
if (info == null) {
statusNullCount.incrementAndGet();
continue;
}

String[] parts = info.split(":");
if (parts.length < 3) continue;

String requestId = requestIds.toArray(new String[0])[i];
Long userId = Long.parseLong(parts[2]);
Long originalTimestamp = parts.length >= 4 ? Long.parseLong(parts[3]) : System.currentTimeMillis();
if (parts.length < 3) {
invalidStatusCount.incrementAndGet();
continue;
}

String requestId = requestIds.get(i);
Long userId;
Long originalTimestamp;
try {
userId = Long.parseLong(parts[2]);
originalTimestamp = parts.length >= 4 ? Long.parseLong(parts[3]) : System.currentTimeMillis();
} catch (NumberFormatException e) {
invalidStatusCount.incrementAndGet();
continue;
}

// 상태 변경 (SET)
String statusKey = statusKeys.get(i);
Expand All @@ -97,11 +120,16 @@ public Object execute(RedisOperations operations) {
content.put("requestId", requestId);
content.put("timestamp", String.valueOf(originalTimestamp));
operations.opsForStream().add(LessonApplyStreamConstant.STREAM_KEY, content);
xaddAttemptCount.incrementAndGet();
}
return null;
}
});

log.info(
"Admission diagnostics. lessonId={}, dequeuedCount={}, statusKeyCount={}, statusNullCount={}, invalidStatusCount={}, xaddAttemptCount={}",
lessonId, requestIds.size(), statusKeys.size(), statusNullCount.get(), invalidStatusCount.get(),
xaddAttemptCount.get());
log.debug("Admitted {} users to MQ via pipeline for lesson: {}", requestIds.size(), lessonId);
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.threestar.trainus.domain.lesson.issue;

import java.time.Duration;
import java.util.Comparator;
import java.util.List;
import java.util.Optional;

import org.springframework.beans.factory.annotation.Qualifier;
Expand Down Expand Up @@ -51,12 +53,13 @@ public Optional<Long> getRank(Long lessonId, String requestId) {
}

// 특정 레슨 대기열에서 가장 오래된 N명을 꺼내기
public java.util.Set<String> dequeue(Long lessonId, long count) {
public List<String> dequeue(Long lessonId, long count) {
String waitingRoomKey = String.format(LessonApplyStreamConstant.WAITING_ROOM_KEY, lessonId);
return coreRedisTemplate.opsForZSet()
.popMin(waitingRoomKey, count)
.stream()
.sorted(Comparator.comparing(tuple -> tuple.getScore() == null ? Double.MAX_VALUE : tuple.getScore()))
.map(tuple -> tuple.getValue())
.collect(java.util.stream.Collectors.toSet());
.toList();
}
}
Loading