Conversation
Closed
1 task
dlsrks1021
reviewed
Jul 31, 2025
|
|
||
| roomService.disconnectOrExitRoom(roomId, userPrincipal); | ||
| } | ||
| missedPongCounter.remove(sessionId); |
Collaborator
There was a problem hiding this comment.
[L5-참고의견]
미리 정의된 cleanSession 메서드를 사용하셔도 될 것 같습니다.
| private void handleSessionHeartbeat(SimpUser user, SimpSession session) { | ||
| String sessionId = session.getId(); | ||
|
|
||
| /* pong */ |
Collaborator
There was a problem hiding this comment.
[L5-참고의견]
서버에서는 HEARTBEAT ping을 전송하는 것 같은데, 혹시 해당 주석 부분이 pong이 맞는지 확인 부탁드립니다.
Collaborator
Author
There was a problem hiding this comment.
헉!!!! 맞아요 이부분은 서버가 보내는거니까 ping이 맞습니다
# Conflicts: # backend/src/main/java/io/f1/backend/domain/game/websocket/HeartbeatMonitor.java
dlsrks1021
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
🪐 작업 내용
stomp의 기본 하트비트를 설정하지않고 send 요청으로 하트비트를 구현(ping-pong)ping을 보내면서 카운트를 1 증가시키고,pong응답이 오면 카운트를 0으로 초기화.ping을 보내는건 스케줄러로 구현하였고 연결된 세션이 있을때만 동작15초 간격으로
ping보내고pong받기deactivate()하는 로직 구현 필요📚 Reference
✅ Check List