Skip to content

[#388] fix(users): users 페이지 레이아웃시프팅 해결 시도#389

Merged
peachPetal merged 2 commits into
devfrom
fix/users-page-layout
Jan 12, 2026
Merged

[#388] fix(users): users 페이지 레이아웃시프팅 해결 시도#389
peachPetal merged 2 commits into
devfrom
fix/users-page-layout

Conversation

@peachPetal
Copy link
Copy Markdown
Collaborator

📖 개요

  • users 페이지의 레이아웃 시프팅 해결 시도

📌 관련 이슈

🛠️ 상세 작업 내용

  • users-dashboard-header와 users-tab-content가 SSR에서 initialData를 입력받도록 수정해서
  • 레이아웃 시프팅 해결 시도

✅ PR 체크리스트

  • 기능 테스트
  • UI/레이아웃 확인
  • 타입 정의 및 로직 셀프 리뷰
  • 불필요한 주석 및 코드 제거
  • pnpm build 로 실행 테스트
  • 다른 기능에 영향 없는지 테스트

📸 스크린샷 (Optional)

N/A

⚠️ 주의 사항 (Optional)

N/A

👥 리뷰 확인 사항 (Optional)

N/A

@github-actions github-actions Bot added the fix 버그 혹은 코드 수정 label Jan 12, 2026
@sageherb sageherb requested a review from Copilot January 12, 2026 00:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes layout shifting issues on the users page by enabling SSR components to receive initial data directly, preventing unnecessary loading states during hydration.

Changes:

  • Modified UserDashboardHeader and UserTabContent components to accept initialData prop
  • Updated getUserProfileServer to return undefined instead of null and include userId field
  • Passed profile data from layout and page components to their respective children

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/widgets/user/ui/user-dashboard-header.tsx Added initialData prop to receive SSR-fetched user profile
src/screens/user/ui/user-tab-content.tsx Added initialData prop to receive SSR-fetched user profile
src/entities/user/api/user-api.server.ts Changed return value from null to undefined and added userId field to response
src/app/(protected)/users/[userId]/layout.tsx Passed fetched profile data to UserDashboardHeader
src/app/(protected)/users/[userId]/[tab]/page.tsx Fetched profile on server and passed to UserTabContent

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/widgets/user/ui/user-dashboard-header.tsx Outdated
Comment thread src/widgets/user/ui/user-dashboard-header.tsx Outdated
@peachPetal peachPetal force-pushed the fix/users-page-layout branch from 6fdbd8c to 5e56733 Compare January 12, 2026 02:51
@peachPetal peachPetal merged commit ac1a334 into dev Jan 12, 2026
@peachPetal peachPetal deleted the fix/users-page-layout branch January 12, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그 혹은 코드 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] users 레이아웃 시프팅

5 participants