[#388] fix(users): users 페이지 레이아웃시프팅 해결 시도#389
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes layout shifting issues on the users page by enabling SSR components to receive initial data directly, preventing unnecessary loading states during hydration.
Changes:
- Modified
UserDashboardHeaderandUserTabContentcomponents to acceptinitialDataprop - Updated
getUserProfileServerto returnundefinedinstead ofnulland includeuserIdfield - Passed profile data from layout and page components to their respective children
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/widgets/user/ui/user-dashboard-header.tsx | Added initialData prop to receive SSR-fetched user profile |
| src/screens/user/ui/user-tab-content.tsx | Added initialData prop to receive SSR-fetched user profile |
| src/entities/user/api/user-api.server.ts | Changed return value from null to undefined and added userId field to response |
| src/app/(protected)/users/[userId]/layout.tsx | Passed fetched profile data to UserDashboardHeader |
| src/app/(protected)/users/[userId]/[tab]/page.tsx | Fetched profile on server and passed to UserTabContent |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sageherb
approved these changes
Jan 12, 2026
elecharu
approved these changes
Jan 12, 2026
sehyun0518
approved these changes
Jan 12, 2026
6fdbd8c to
5e56733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 개요
📌 관련 이슈
🛠️ 상세 작업 내용
✅ PR 체크리스트
pnpm build로 실행 테스트📸 스크린샷 (Optional)
N/A
N/A
👥 리뷰 확인 사항 (Optional)
N/A