Skip to content

채택 기능 적용 범위 수정 (#375) #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luckhee merged 1 commit into from
Oct 15, 2025
Merged

채택 기능 적용 범위 수정 (#375) #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion back/src/main/java/com/back/domain/post/comment/service/PostCommentService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public void adoptComment(Long commentId, Member member) {
Post post = postComment.getPost();

validateIsPostAuthor(post, member);
validatePostType(post);
//validatePostType(post);
validateAlreadyAdoptedComment(postComment);
validateAlreadyExistsAdoptedComment(post);

Expand Down
37 changes: 20 additions & 17 deletions back/src/test/java/com/back/domain/post/comment/service/PostCommentServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,23 +335,26 @@ void adoptComment_notPostAuthor_failure() {
.hasMessage("400 : 채택 권한이 없습니다.");
}

@Test
@DisplayName("질문 게시글이 아닌 게시글의 댓글 채택 시도 시 실패")
void adoptComment_notQuestionPost_failure() {
// given
Member postAuthor = MemberFixture.create(1L, "author@test.com", "Author", "password", Member.Role.MENTEE);
Member commenter = MemberFixture.create(2L, "commenter@test.com", "Commenter", "password", Member.Role.MENTOR);
Post informationPost = createDefaultPost(postAuthor);
PostComment comment = createComment(commenter, informationPost, "일반 댓글");
Long commentId = 1L;

when(postCommentRepository.findById(commentId)).thenReturn(Optional.of(comment));

// when & then
assertThatThrownBy(() -> postCommentService.adoptComment(commentId, postAuthor))
.isInstanceOf(ServiceException.class)
.hasMessage("400 : 질문 게시글만 채택된 댓글을 가질 수 있습니다.");
}
// 운영 정책상
// 변경 질문게시글 에서만 채택 가능 -> 전체 게시글에서 채택 가능
//
// @Test
// @DisplayName("질문 게시글이 아닌 게시글의 댓글 채택 시도 시 실패")
// void adoptComment_notQuestionPost_failure() {
// // given
// Member postAuthor = MemberFixture.create(1L, "author@test.com", "Author", "password", Member.Role.MENTEE);
// Member commenter = MemberFixture.create(2L, "commenter@test.com", "Commenter", "password", Member.Role.MENTOR);
// Post informationPost = createDefaultPost(postAuthor);
// PostComment comment = createComment(commenter, informationPost, "일반 댓글");
// Long commentId = 1L;
//
// when(postCommentRepository.findById(commentId)).thenReturn(Optional.of(comment));
//
// // when & then
// assertThatThrownBy(() -> postCommentService.adoptComment(commentId, postAuthor))
// .isInstanceOf(ServiceException.class)
// .hasMessage("400 : 질문 게시글만 채택된 댓글을 가질 수 있습니다.");
// }

@Test
@DisplayName("이미 채택된 댓글을 다시 채택 시도 시 실패")
Expand Down