Skip to content

Commit baa7a3f

Browse files
committed
refactor: 코드리뷰 수정
1 parent a7c2385 commit baa7a3f

2 files changed

Lines changed: 13 additions & 7 deletions

File tree

src/main/java/com/back/web7_9_codecrete_be/domain/artists/entity/ArtistLike.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,24 @@
44
import jakarta.persistence.*;
55
import lombok.Getter;
66
import lombok.NoArgsConstructor;
7+
import org.springframework.data.annotation.CreatedDate;
8+
import org.springframework.data.jpa.domain.support.AuditingEntityListener;
79

810
import java.time.LocalDateTime;
911

12+
1013
@Entity
1114
@Getter
1215
@NoArgsConstructor
16+
@EntityListeners(AuditingEntityListener.class)
1317
@Table(name = "artist_like")
1418
public class ArtistLike {
1519
@Id
1620
@GeneratedValue(strategy = GenerationType.IDENTITY)
1721
@Column(name = "artist_like_id")
1822
private long id;
1923

24+
@CreatedDate
2025
@Column(name = "created_date", nullable = false)
2126
private LocalDateTime createdDate;
2227

@@ -29,7 +34,6 @@ public class ArtistLike {
2934
private Artist artist;
3035

3136
public ArtistLike(Artist artist, User user) {
32-
this.createdDate = LocalDateTime.now();
3337
this.artist = artist;
3438
this.user = user;
3539
}

src/main/java/com/back/web7_9_codecrete_be/domain/artists/service/ArtistService.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,12 @@ public class ArtistService {
2929
private final ArtistRepository artistRepository;
3030
private final GenreService genreService;
3131
private final ArtistLikeRepository artistLikeRepository;
32-
private final Rq rq;
32+
33+
@Transactional(readOnly = true)
34+
public Artist findArtist(Long artistId) {
35+
return artistRepository.findById(artistId)
36+
.orElseThrow(() -> new BusinessException(ArtistErrorCode.ARTIST_NOT_FOUND));
37+
}
3338

3439
@Transactional
3540
public int setArtist() {
@@ -131,9 +136,7 @@ public List<SearchResponse> search(String artistName) {
131136

132137
@Transactional
133138
public void likeArtist(Long artistId, User user) {
134-
Artist artist = artistRepository.findById(artistId)
135-
.orElseThrow(() -> new BusinessException(ArtistErrorCode.ARTIST_NOT_FOUND));
136-
139+
Artist artist = findArtist(artistId);
137140
if(artistLikeRepository.existsByArtistAndUser(artist, user)) {
138141
throw new BusinessException(ArtistErrorCode.LIKES_ALREADY_EXISTS);
139142
}
@@ -143,8 +146,7 @@ public void likeArtist(Long artistId, User user) {
143146

144147
@Transactional
145148
public void deleteLikeArtist(Long artistId, User user) {
146-
Artist artist = artistRepository.findById(artistId)
147-
.orElseThrow(() -> new BusinessException(ArtistErrorCode.ARTIST_NOT_FOUND));
149+
Artist artist = findArtist(artistId);
148150
ArtistLike likes = artistLikeRepository.findByArtistAndUser(artist, user)
149151
.orElseThrow(() -> new BusinessException(ArtistErrorCode.LIKES_NOT_FOUND));
150152
artistLikeRepository.delete(likes);

0 commit comments

Comments
 (0)