-
Notifications
You must be signed in to change notification settings - Fork 2
[Artist] 아티스트 검색 #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Artist] 아티스트 검색 #100
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 14 additions & 1 deletion
15
src/main/java/com/back/web7_9_codecrete_be/domain/artists/dto/request/CreateRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,22 @@ | ||
| package com.back.web7_9_codecrete_be.domain.artists.dto.request; | ||
|
|
||
| import com.back.web7_9_codecrete_be.domain.artists.entity.ArtistType; | ||
| import jakarta.validation.constraints.NotNull; | ||
| import jakarta.validation.constraints.Size; | ||
|
|
||
| public record CreateRequest( | ||
| @NotNull(message = "아티스트 이름은 필수로 입력해야합니다.") | ||
| @Size(max = 200, message = "아티스트 이름은 200자를 넘길 수 없습니다.") | ||
| String artistName, | ||
|
|
||
| @Size(max = 150, message = "아티스트 그룹 이름은 150자를 넘길 수 없습니다.") | ||
| String artistGroup, | ||
| String artistType, | ||
|
|
||
| @NotNull(message = "아티스트 타입은 필수로 입력해야합니다(SOLO or GROUP)") | ||
| ArtistType artistType, | ||
|
|
||
| @NotNull(message = "장르는 필수로 입력해야합니다.") | ||
| @Size(max = 30, message = "장르는 30자를 넘길 수 없습니다.") | ||
| String genreName | ||
| ) { | ||
| } |
9 changes: 9 additions & 0 deletions
9
src/main/java/com/back/web7_9_codecrete_be/domain/artists/dto/request/SearchRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.back.web7_9_codecrete_be.domain.artists.dto.request; | ||
|
|
||
| import jakarta.validation.constraints.NotBlank; | ||
|
|
||
| public record SearchRequest( | ||
| @NotBlank(message = "검색어를 입력해주세요") | ||
| String artistName | ||
| ) { | ||
| } | ||
11 changes: 10 additions & 1 deletion
11
src/main/java/com/back/web7_9_codecrete_be/domain/artists/dto/request/UpdateRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,18 @@ | ||
| package com.back.web7_9_codecrete_be.domain.artists.dto.request; | ||
|
|
||
| import com.back.web7_9_codecrete_be.domain.artists.entity.ArtistType; | ||
| import jakarta.validation.constraints.Size; | ||
|
|
||
| public record UpdateRequest( | ||
| @Size(max = 200, message = "아티스트 이름은 200자를 넘길 수 없습니다.") | ||
| String artistName, | ||
|
|
||
| @Size(max = 150, message = "아티스트 그룹 이름은 150자를 넘길 수 없습니다.") | ||
| String artistGroup, | ||
| String artistType, | ||
|
|
||
| ArtistType artistType, | ||
|
|
||
| @Size(max = 30, message = "장르 이름은 30자를 넘길 수 없습니다.") | ||
| String genreName | ||
| ) { | ||
| } |
4 changes: 3 additions & 1 deletion
4
...n/java/com/back/web7_9_codecrete_be/domain/artists/dto/response/ArtistDetailResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/main/java/com/back/web7_9_codecrete_be/domain/artists/dto/response/SearchResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.back.web7_9_codecrete_be.domain.artists.dto.response; | ||
|
|
||
| import com.back.web7_9_codecrete_be.domain.artists.entity.Artist; | ||
|
|
||
| public record SearchResponse( | ||
| String artistName, | ||
| String artistGroup, | ||
| int likeCount | ||
| ) { | ||
| public static SearchResponse from(Artist artist) { | ||
| return new SearchResponse( | ||
| artist.getArtistName(), | ||
| artist.getArtistGroup(), | ||
| artist.getLikeCount() | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
src/main/java/com/back/web7_9_codecrete_be/domain/artists/entity/ArtistType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.back.web7_9_codecrete_be.domain.artists.entity; | ||
|
|
||
| public enum ArtistType { | ||
| SOLO, | ||
| GROUP | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,9 @@ | |
| import com.back.web7_9_codecrete_be.domain.artists.dto.request.UpdateRequest; | ||
| import com.back.web7_9_codecrete_be.domain.artists.dto.response.ArtistListResponse; | ||
| import com.back.web7_9_codecrete_be.domain.artists.dto.response.ArtistDetailResponse; | ||
| import com.back.web7_9_codecrete_be.domain.artists.dto.response.SearchResponse; | ||
| import com.back.web7_9_codecrete_be.domain.artists.entity.Artist; | ||
| import com.back.web7_9_codecrete_be.domain.artists.entity.ArtistType; | ||
| import com.back.web7_9_codecrete_be.domain.artists.entity.Genre; | ||
| import com.back.web7_9_codecrete_be.domain.artists.repository.ArtistRepository; | ||
| import com.back.web7_9_codecrete_be.domain.artists.repository.ArtistLikeRepository; | ||
|
|
@@ -30,7 +32,7 @@ public int setArtist() { | |
| } | ||
|
|
||
| @Transactional | ||
| public Artist createArtist(String artistName, String artistGroup, String artistType, String genreName) { | ||
| public Artist createArtist(String artistName, String artistGroup, ArtistType artistType, String genreName) { | ||
| Genre genre = genreService.findByGenreName(genreName); | ||
| if(artistRepository.existsByArtistName(artistName) || artistRepository.existsByNameKo(artistName)) { | ||
| throw new BusinessException(ArtistErrorCode.ARTIST_ALREADY_EXISTS); | ||
|
|
@@ -85,8 +87,8 @@ public void updateArtist(Long id, UpdateRequest req) { | |
| changed = true; | ||
| } | ||
|
|
||
| if (req.artistType() != null && !req.artistType().isBlank()) { | ||
| artist.changeType(req.artistType().trim()); | ||
| if (req.artistType() != null) { | ||
| artist.changeType(req.artistType()); | ||
| changed = true; | ||
| } | ||
|
|
||
|
|
@@ -97,7 +99,7 @@ public void updateArtist(Long id, UpdateRequest req) { | |
| } | ||
|
|
||
| if (!changed) { | ||
| throw new BusinessException(ArtistErrorCode.INVALID_UPDATE_REQUEST); // "수정할 값이 없습니다" | ||
| throw new BusinessException(ArtistErrorCode.INVALID_UPDATE_REQUEST); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -108,4 +110,19 @@ public void delete(Long id) { | |
| artistRepository.delete(artist); | ||
| } | ||
|
|
||
| @Transactional | ||
| public List<SearchResponse> search(String artistName) { | ||
|
Comment on lines
+113
to
+114
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 조회이기 때문에 @transactional(readOnly = true)로 하면 더 좋을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 넹 추가하겠습니다!! |
||
|
|
||
| List<Artist> artists = | ||
| artistRepository.findAllByArtistNameContainingIgnoreCaseOrNameKoContainingIgnoreCase(artistName, artistName); | ||
|
|
||
| if (artists.isEmpty()) { | ||
| throw new BusinessException(ArtistErrorCode.ARTIST_NOT_FOUND); | ||
| } | ||
|
|
||
| return artists.stream() | ||
| .map(SearchResponse::from) | ||
| .toList(); | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notblank 외에도 다른 유효성 검증 수단을 추가하면 좋을 것 같습니다.
(정작 이 글 쓰는 팀장도 유효성 검증 수단을 빼먹은게... 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 추가하겠습니다!!