-
Notifications
You must be signed in to change notification settings - Fork 2
[Concert] 공연 조회 관련 예외 처리 및 오류 코드 추가 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 0 additions & 1 deletion
1
...in/java/com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertLikeResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertTicketTimeSetRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,18 @@ | ||
| package com.back.web7_9_codecrete_be.domain.concerts.dto.concert; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import jakarta.validation.constraints.NotEmpty; | ||
| import lombok.Getter; | ||
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| @Getter | ||
| public class ConcertTicketTimeSetRequest { | ||
| @Schema(description = "공연 ID 입니다.") | ||
| @NotEmpty | ||
| private Long concertId; | ||
|
|
||
| @Schema(description = "티켓팅 시간입니다.") | ||
| @NotEmpty | ||
| private LocalDateTime ticketTime; | ||
| } |
10 changes: 10 additions & 0 deletions
10
...n/java/com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertUpdateRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,46 @@ | ||
| package com.back.web7_9_codecrete_be.domain.concerts.dto.concert; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import jakarta.validation.constraints.NotEmpty; | ||
| import lombok.Getter; | ||
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| @Getter | ||
| public class ConcertUpdateRequest { | ||
| @Schema(description = "수정할 대상이 될 공연 ID 입니다.") | ||
| @NotEmpty | ||
| private Long concertId; | ||
|
|
||
| @Schema(description = "공연 이름입니다.") | ||
| @NotEmpty | ||
| private String name; | ||
|
|
||
| @Schema(description = "공연 설명입니다.") | ||
| @NotEmpty | ||
| private String description; | ||
|
|
||
| @Schema(description = "공연장 ID 입니다.") | ||
| @NotEmpty | ||
| private Long placeId; | ||
|
|
||
| @Schema(description = "공연 시작 날짜입니다.") | ||
| @NotEmpty | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NotEmpty 어노테이션이 String, List 등 에서만 사용이 가능하고 long, int, localdate에서는 사용 시 런타임 에러가 발생할 수 있다고 합니다! |
||
| private LocalDate StartDate; | ||
|
|
||
| @Schema(description = "공연 종료 날짜입니다.") | ||
| @NotEmpty | ||
| private LocalDate EndDate; | ||
|
|
||
| @Schema(description = "공연 포스터 URL 입니다.") | ||
| @NotEmpty | ||
| private String posterUrl; | ||
|
|
||
| @Schema(description = "공연 티켓 최고가입니다.") | ||
| @NotEmpty | ||
| private int maxPrice; | ||
|
|
||
| @Schema(description = "공연 티켓 최저가입니다.") | ||
| @NotEmpty | ||
| private int minPrice; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NotEmpty 어노테이션이 문자열 공백(" ")은 허용해주는 걸로 알고있어서 NotBlank 로 선언해주시는게 더 좋을 것 같습니다!!