[User] 유저 프로필 이미지 AWS S3 활용한 업로드 처리#138
Merged
Merged
Conversation
⭐ JaCoCo CoverageLine Coverage: 4.77% 📄 Coverage DetailsOverall Line Coverage: 4.74% (126 covered / 2658 lines) Package Summary (lowest first)
Lowest Covered Classes (Top 20)
Changed Classes (from this PR)
🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20356008193 |
Creamcheesepie
approved these changes
Dec 18, 2025
| @PatchMapping(value = "/profile-image", consumes = MediaType.MULTIPART_FORM_DATA_VALUE) | ||
| public RsData<?> updateProfileImage( | ||
| @RequestPart MultipartFile file | ||
| @RequestPart("file") MultipartFile file |
Collaborator
There was a problem hiding this comment.
파일에 대한 유효성 검증을 추가하면 좋을 것 같습니다 ex) 확장자, 파일명
| private final EmailService emailService; | ||
|
|
||
| private static final long MAX_PROFILE_IMAGE_SIZE = 10 * 1024 * 1024; // 10MB | ||
|
|
Collaborator
There was a problem hiding this comment.
s3가 데이터를 못 받는 상황에 대한 테스트가 필요할 것 같습니다
heygeeji
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
🚀 PR 개요
📌 변경 사항
🧪 테스트 방법
📸 스크린샷 (선택)