[Location] 외부 api 테스트 코드 작성 by tobbot16 · Pull Request #140 · prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE

tobbot16 · 2025-12-18T15:56:42Z

🔗 관련 이슈

관련된 이슈 번호를 연결해주세요.
Close #이슈번호 를 쓰면 PR merge 시 자동으로 close 됩니다.

Close [Location] 사용자 위치정보 및 외부 api test코드 작성 #105

🚀 PR 개요

이 PR이 어떤 변경을 포함하고 있는지 간단히 설명해주세요.

외부 api 테스트코드(tmap, kakaomap) 서비스 테스트코드 작성했습니다
컨트롤러 부분은 끝내 해결되지 않아, 방학때 시간나면 고쳐보겠습니다!

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

🧪 테스트 방법

변경된 내용을 어떻게 테스트했는지 구체적으로 적어주세요.

테스트 방법은 그냥 테스트버튼 누르면 됩니다.
자세한 사항은 주석처리 및 설명을 첨부했으니, 봐주시면 감사하겠습니다!

📸 스크린샷 (선택)

UI 변경 또는 시각적으로 확인할 수 있는 변경이 있다면 첨부해주세요.

⚠️ 참고 사항

리뷰어가 알아야 할 사항이 있다면 자유롭게 작성해주세요.

yml부분과 WebClientConfig 부분을 고쳤는데, 혹시 오류나면 다시 롤백 해놓겠습니다!

github-actions · 2025-12-18T15:58:32Z

Test Results

6 tests +5 6 ✅ +5 0s ⏱️ ±0s
3 suites +2 0 💤 ±0
3 files +2 0 ❌ ±0

Results for commit 55751ec. ± Comparison against base commit 32c4a63.

github-actions · 2025-12-18T15:58:49Z

⭐ JaCoCo Coverage

Line Coverage: 7.18%

📄 Coverage Details

Overall Line Coverage: 7.14% (184 covered / 2577 lines)

Package Summary (lowest first)

Package	Line %	Covered	Missed
`com/back/web7_9_codecrete_be/domain/chats/controller`	0.00%	0	2
`com/back/web7_9_codecrete_be/domain/chats/service`	0.00%	0	38
`com/back/web7_9_codecrete_be/domain/plans/controller`	0.00%	0	43
`com/back/web7_9_codecrete_be/domain/location/controller`	0.00%	0	14
`com/back/web7_9_codecrete_be/global/rsData`	0.00%	0	11
`com/back/web7_9_codecrete_be/domain/chats/entity`	0.00%	0	4
`com/back/web7_9_codecrete_be/domain/location/entity`	0.00%	0	15
`com/back/web7_9_codecrete_be/global/scheduler`	0.00%	0	3
`com/back/web7_9_codecrete_be/domain/auth/entity`	0.00%	0	0
`com/back/web7_9_codecrete_be/domain/auth/service`	0.00%	0	161
`com/back/web7_9_codecrete_be/domain/plans/service`	0.00%	0	278
`com/back/web7_9_codecrete_be/global/initData`	0.00%	0	51
`com/back/web7_9_codecrete_be/domain/users/controller`	0.00%	0	20
`com/back/web7_9_codecrete_be/domain/email/entity`	0.00%	0	6
`com/back/web7_9_codecrete_be/domain/users/service`	0.00%	0	59
`com/back/web7_9_codecrete_be/domain/auth/controller`	0.00%	0	24
`com/back/web7_9_codecrete_be/domain/artists/controller`	0.00%	0	27
`com/back/web7_9_codecrete_be/global/aspect`	0.00%	0	4
`com/back/web7_9_codecrete_be/global/wikidata`	0.36%	1	279
`com/back/web7_9_codecrete_be/domain/artists/service`	0.77%	3	388
`com/back/web7_9_codecrete_be/global/musicbrainz`	0.99%	1	100
`com/back/web7_9_codecrete_be/domain/email/service`	1.37%	1	72
`com/back/web7_9_codecrete_be/domain/concerts/controller`	3.70%	1	26
`com/back/web7_9_codecrete_be/domain/concerts/entity`	4.29%	3	67
`com/back/web7_9_codecrete_be/domain/concerts/service`	5.12%	22	408
`com/back/web7_9_codecrete_be/domain/artists/entity`	8.33%	4	44
`com/back/web7_9_codecrete_be/global/rq`	12.90%	4	27
`com/back/web7_9_codecrete_be/domain/users/util`	14.29%	1	6
`com/back/web7_9_codecrete_be/domain/plans/entity`	25.00%	21	63
`com/back/web7_9_codecrete_be/global/security`	26.36%	29	81
`com/back/web7_9_codecrete_be/domain/users/entity`	29.27%	12	29
`com/back/web7_9_codecrete_be/global/storage`	33.33%	1	2
`com/back/web7_9_codecrete_be/global/spotify`	35.71%	5	9
`com/back/web7_9_codecrete_be/domain/location/service`	64.44%	58	32
`com/back/web7_9_codecrete_be/global/doc`	100.00%	17	0

Lowest Covered Classes (Top 20)

Class	Line %	Missed
`com.back.web7_9_codecrete_be.domain.plans.service.PlanService`	0.00%	278
`com.back.web7_9_codecrete_be.domain.auth.service.AuthService`	0.00%	98
`com.back.web7_9_codecrete_be.domain.artists.service.ArtistService`	0.00%	78
`com.back.web7_9_codecrete_be.domain.concerts.service.ConcertService`	0.00%	61
`com.back.web7_9_codecrete_be.domain.concerts.service.ConcertNotifyService`	0.00%	57
`com.back.web7_9_codecrete_be.domain.users.service.UserService`	0.00%	55
`com.back.web7_9_codecrete_be.global.initData.BaseInitData`	0.00%	51
`com.back.web7_9_codecrete_be.domain.plans.controller.PlanController`	0.00%	43
`com.back.web7_9_codecrete_be.domain.concerts.entity.Concert`	0.00%	40
`com.back.web7_9_codecrete_be.global.security.JwtTokenProvider`	0.00%	37
`com.back.web7_9_codecrete_be.domain.plans.entity.Schedule`	0.00%	34
`com.back.web7_9_codecrete_be.domain.artists.entity.Artist`	0.00%	31
`com.back.web7_9_codecrete_be.domain.location.service.LocationService`	0.00%	30
`com.back.web7_9_codecrete_be.domain.users.entity.User`	0.00%	29
`com.back.web7_9_codecrete_be.domain.chats.service.ChatPolicyService`	0.00%	27
`com.back.web7_9_codecrete_be.domain.auth.service.TokenService`	0.00%	27
`com.back.web7_9_codecrete_be.domain.artists.controller.ArtistsController`	0.00%	27
`com.back.web7_9_codecrete_be.domain.auth.controller.AuthController`	0.00%	24
`com.back.web7_9_codecrete_be.domain.users.controller.UserController`	0.00%	20
`com.back.web7_9_codecrete_be.domain.plans.entity.Plan`	0.00%	18

Changed Classes (from this PR)

Source (PR)	Class Prefix	Line %	Missed
`src/main/java/com/back/web7_9_codecrete_be/domain/location/controller/KakaoApiController.java`	`com.back.web7_9_codecrete_be.domain.location.controller.KakaoApiController`	0.00%	4
`src/main/java/com/back/web7_9_codecrete_be/domain/location/controller/TmapApiController.java`	`com.back.web7_9_codecrete_be.domain.location.controller.TmapApiController`	0.00%	1
`src/main/java/com/back/web7_9_codecrete_be/global/config/WebClientConfig.java`	`com.back.web7_9_codecrete_be.global.config.WebClientConfig`	0.00%	0

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20342936237

larama-C

수고하셨습니다! 컨트롤러 테스트 작동 안하는 부분은 방법을 좀 더 고민해보겠습니다!

Creamcheesepie

외부 API 응답에 관한 테스트를 진행하신게 인상깊네요

tobbot16 · 2025-12-19T00:43:02Z

수고하셨습니다! 컨트롤러 테스트 작동 안하는 부분은 방법을 좀 더 고민해보겠습니다!

넵 감사합니다! 저도 계속 고민해보겠습니다!

ys0221

고생하셨습니다!!

tobbot16 added 5 commits December 17, 2025 14:05

feat: 불필요한 테스트 컨트롤러 제거

20dc8a2

feat: kakaoController param값 변경

d771f0c

feat: 외부 api 컨트롤러 이름 변경

ab30cc5

feat: service부분 테스트 코드 작성, but 컨트롤러는 중도포기..

9dc30f8

feat: 카카오 서비스 테스트 주석추가

55751ec

tobbot16 self-assigned this Dec 18, 2025

tobbot16 added the Feature label Dec 18, 2025

larama-C approved these changes Dec 19, 2025

View reviewed changes

Creamcheesepie approved these changes Dec 19, 2025

View reviewed changes

ys0221 approved these changes Dec 19, 2025

View reviewed changes

Creamcheesepie merged commit defb1e6 into main Dec 19, 2025
2 checks passed

Creamcheesepie deleted the feat/#105 branch December 19, 2025 00:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Location] 외부 api 테스트 코드 작성#140

[Location] 외부 api 테스트 코드 작성#140
Creamcheesepie merged 5 commits into
mainfrom
feat/#105

tobbot16 commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 18, 2025

Uh oh!

github-actions Bot commented Dec 18, 2025

Uh oh!

larama-C left a comment

Uh oh!

Creamcheesepie left a comment

Uh oh!

tobbot16 commented Dec 19, 2025

Uh oh!

ys0221 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tobbot16 commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 관련 이슈

🚀 PR 개요

📌 변경 사항

🧪 테스트 방법

📸 스크린샷 (선택)

⚠️ 참고 사항

yml부분과 WebClientConfig 부분을 고쳤는데, 혹시 오류나면 다시 롤백 해놓겠습니다!

Uh oh!

github-actions Bot commented Dec 18, 2025

Test Results

Uh oh!

github-actions Bot commented Dec 18, 2025

⭐ JaCoCo Coverage

📄 Coverage Details

Uh oh!

larama-C left a comment

Choose a reason for hiding this comment

Uh oh!

Creamcheesepie left a comment

Choose a reason for hiding this comment

Uh oh!

tobbot16 commented Dec 19, 2025

Uh oh!

ys0221 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tobbot16 commented Dec 18, 2025 •

edited

Loading