[Location] 카카오 모빌리티 api 연동 완료#159
Merged
Merged
Conversation
⭐ JaCoCo CoverageLine Coverage: 6.74% 📄 Coverage DetailsOverall Line Coverage: 6.70% (190 covered / 2835 lines) Package Summary (lowest first)
Lowest Covered Classes (Top 20)
Changed Classes (from this PR)
🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20425625308 |
heygeeji
reviewed
Dec 22, 2025
| @Bean | ||
| public WebClient TmapClient(){ | ||
| return WebClient.builder() | ||
| public RestClient TmapRestClient(){ |
Collaborator
There was a problem hiding this comment.
컨벤션상 메소드명 첫글자는 소문자로 바꾸는게 좋을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
아하 넵 감사합니다! 바로 수정하겠습니다
Creamcheesepie
approved these changes
Dec 22, 2025
| private String tmapBaseUrl; | ||
|
|
||
| @Value("https://apis-navi.kakaomobility.com") | ||
| private String kakaoMobilityUrl; |
Collaborator
There was a problem hiding this comment.
위의 tmap이랑 같은 처리로 하시면 좋을 것 같습니다.
| private final RestClient kakaoMobilityClient; | ||
|
|
||
| public List<KakaoLocalResponse.Document> searchNearbyRestaurants(double lat, double lng) { | ||
|
|
Collaborator
There was a problem hiding this comment.
추후 확장을 고려하여 query, categoryGroupCode를 enum 타입으로 처리하고, searchNearbyPlaces 같은 메소드�공통처리를 하는 것도 좋을 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
🚀 PR 개요
📌 변경 사항
🧪 테스트 방법
📸 스크린샷 (선택)