[Plan] 링크 기반 계획 공유 & UK 검증#171
Merged
Merged
Conversation
⭐ JaCoCo CoverageLine Coverage: 6.72% 📄 Coverage DetailsOverall Line Coverage: 6.68% (189 covered / 2830 lines) Package Summary (lowest first)
Lowest Covered Classes (Top 20)
Changed Classes (from this PR)
🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20439472128 |
Creamcheesepie
approved these changes
Dec 22, 2025
| private String shareToken; | ||
|
|
||
| @Schema(description = "공유 링크", example = "/plans/share/550e8400-e29b-41d4-a716-446655440000") | ||
| private String shareLink; |
Collaborator
There was a problem hiding this comment.
UUID 쓰신 것은 좋아 보이는데, 너무 길어서 조금만 줄이시면 좋을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
UUID 쓰신 것은 좋아 보이는데, 너무 길어서 조금만 줄이시면 좋을 것 같습니다!
바로 반영하겠습니다!
| // DB 레벨에서 이미 참가자인지 확인 (유니크 제약조건 검증) | ||
| boolean isAlreadyParticipant = planParticipantRepository.existsByUser_IdAndPlan_PlanId( | ||
| user.getId(), plan.getPlanId()); | ||
|
|
Collaborator
There was a problem hiding this comment.
exist로 검증한 부분이 좋네요
| user.getId(), plan.getPlanId()); | ||
|
|
||
| if (isAlreadyParticipant) { | ||
| // 이미 참가자인 경우 상태를 ACCEPTED로 변경 |
Collaborator
There was a problem hiding this comment.
추후 계획 수락부분에서 변경하시려고 Join에서 accepted로 설정하게 해두신건가요...?
Collaborator
Author
There was a problem hiding this comment.
추후 계획 수락부분에서 변경하시려고 Join에서 accepted로 설정하게 해두신건가요...?
아.. PENDING이 맞는데 초반 설계 단계에서 급하게 하느라 지나갔네요ㅎㅎ 조언 감사합니다!~
수락 기능도 있어서 링크 클릭 시 조회하는 것으로 하겠습니다.
Collaborator
There was a problem hiding this comment.
아래에 계획 수락 부분이 있었는데 accepted라서 당황했어요 ㅋㅋㅋㅋㅋ 혹시 다른 로직에서 검증한다고 일부러 accepted 해두신줄 알았습니다
larama-C
approved these changes
Dec 22, 2025
heygeeji
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
🚀 PR 개요
📌 변경 사항
🧪 테스트 방법
📸 스크린샷 (선택)