Skip to content

[Concert] KopisApiService 부분 리팩토링 및 재시도 로직 추가#249

Merged
Creamcheesepie merged 9 commits into
mainfrom
feat/#239
Jan 5, 2026
Merged

[Concert] KopisApiService 부분 리팩토링 및 재시도 로직 추가#249
Creamcheesepie merged 9 commits into
mainfrom
feat/#239

Conversation

@Creamcheesepie

Copy link
Copy Markdown
Collaborator

🔗 관련 이슈

관련된 이슈 번호를 연결해주세요.
Close #이슈번호 를 쓰면 PR merge 시 자동으로 close 됩니다.

🚀 PR 개요

이 PR이 어떤 변경을 포함하고 있는지 간단히 설명해주세요.

  • KopisApiService 부분의 중복되는 메소드를 추출하고, 로드 실패시 재시도합니다.

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

  • 기능 추가
  • 버그 수정
  • 리팩터링
  • 문서 업데이트
  • 테스트 추가/수정

🧪 테스트 방법

변경된 내용을 어떻게 테스트했는지 구체적으로 적어주세요.

  1. postman 수제 테스트

⚠️ 참고 사항

리뷰어가 알아야 할 사항이 있다면 자유롭게 작성해주세요.

  • 해당 부분 가독성을 조금 올렸습니다.

@github-actions

github-actions Bot commented Jan 3, 2026

Copy link
Copy Markdown

Test Results

33 tests  ±0   33 ✅ ±0   4s ⏱️ ±0s
 6 suites ±0    0 💤 ±0 
 6 files   ±0    0 ❌ ±0 

Results for commit 3d54fe2. ± Comparison against base commit 3f79430.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jan 3, 2026

Copy link
Copy Markdown

⭐ JaCoCo Coverage

Line Coverage: 7.21%

📄 Coverage Details

Overall Line Coverage: 7.20% (419 covered / 5816 lines)

Package Summary (lowest first)
Package Line % Covered Missed
com/back/web7_9_codecrete_be/domain/plans/controller 0.00% 0 63
com/back/web7_9_codecrete_be/domain/chats/entity 0.00% 0 4
com/back/web7_9_codecrete_be/domain/serverTime/entity 0.00% 0 9
com/back/web7_9_codecrete_be/domain/auth/entity 0.00% 0 0
com/back/web7_9_codecrete_be/domain/auth/service 0.00% 0 150
com/back/web7_9_codecrete_be/domain/auth/controller 0.00% 0 24
com/back/web7_9_codecrete_be/domain/community/comment/controller 0.00% 0 7
com/back/web7_9_codecrete_be/domain/community/comment/entity 0.00% 0 12
com/back/web7_9_codecrete_be/domain/serverTime/controller 0.00% 0 3
com/back/web7_9_codecrete_be/domain/location/controller 0.00% 0 55
com/back/web7_9_codecrete_be/domain/location/entity 0.00% 0 15
com/back/web7_9_codecrete_be/global/scheduler 0.00% 0 11
com/back/web7_9_codecrete_be/domain/plans/service 0.00% 0 432
com/back/web7_9_codecrete_be/global/initData 0.00% 0 59
com/back/web7_9_codecrete_be/domain/email/entity 0.00% 0 6
com/back/web7_9_codecrete_be/domain/community/comment/service 0.00% 0 17
com/back/web7_9_codecrete_be/domain/artists/controller 0.00% 0 35
com/back/web7_9_codecrete_be/domain/community/post/controller 0.00% 0 45
com/back/web7_9_codecrete_be/domain/artists/service 0.40% 6 1488
com/back/web7_9_codecrete_be/domain/community/post/service 0.63% 1 158
com/back/web7_9_codecrete_be/global/wikidata 0.89% 5 554
com/back/web7_9_codecrete_be/global/musicbrainz 1.10% 5 448
com/back/web7_9_codecrete_be/global/maniadb 1.22% 1 81
com/back/web7_9_codecrete_be/domain/chats/service 1.57% 2 125
com/back/web7_9_codecrete_be/domain/email/service 1.61% 1 61
com/back/web7_9_codecrete_be/global/flo 1.85% 1 53
com/back/web7_9_codecrete_be/domain/concerts/controller 2.33% 1 42
com/back/web7_9_codecrete_be/domain/concerts/repository 3.45% 1 28
com/back/web7_9_codecrete_be/global/storage 3.57% 2 54
com/back/web7_9_codecrete_be/global/websocket 4.65% 4 82
com/back/web7_9_codecrete_be/domain/serverTime/service 6.25% 3 45
com/back/web7_9_codecrete_be/domain/artists/entity 6.45% 4 58
com/back/web7_9_codecrete_be/domain/artists/service/seed 7.69% 10 120
com/back/web7_9_codecrete_be/global/rq 9.80% 5 46
com/back/web7_9_codecrete_be/domain/chats/controller 10.00% 2 18
com/back/web7_9_codecrete_be/domain/concerts/service 13.71% 75 472
com/back/web7_9_codecrete_be/domain/users/util 14.29% 1 6
com/back/web7_9_codecrete_be/domain/community/post/entity 14.77% 13 75
com/back/web7_9_codecrete_be/domain/plans/entity 21.88% 21 75
com/back/web7_9_codecrete_be/domain/users/service 32.41% 35 73
com/back/web7_9_codecrete_be/domain/location/service 32.78% 59 121
com/back/web7_9_codecrete_be/global/spotify 35.71% 5 9
com/back/web7_9_codecrete_be/global/security 37.38% 40 67
com/back/web7_9_codecrete_be/domain/concerts/entity 38.04% 35 57
com/back/web7_9_codecrete_be/domain/users/controller 55.17% 16 13
com/back/web7_9_codecrete_be/domain/users/entity 64.81% 35 19
com/back/web7_9_codecrete_be/global/rsData 81.82% 9 2
com/back/web7_9_codecrete_be/global/doc 100.00% 17 0
com/back/web7_9_codecrete_be/global/aspect 100.00% 4 0
Lowest Covered Classes (Top 20)
Class Line % Covered Missed
com.back.web7_9_codecrete_be.domain.plans.service.PlanService 0.00% 0 432
com.back.web7_9_codecrete_be.domain.artists.service.EnrichStepExecutor 0.00% 0 130
com.back.web7_9_codecrete_be.domain.artists.service.ArtistService 0.00% 0 95
com.back.web7_9_codecrete_be.domain.auth.service.AuthService 0.00% 0 88
com.back.web7_9_codecrete_be.domain.artists.service.WikidataEnrichHelper 0.00% 0 78
com.back.web7_9_codecrete_be.domain.plans.controller.PlanController 0.00% 0 63
com.back.web7_9_codecrete_be.global.initData.BaseInitData 0.00% 0 59
com.back.web7_9_codecrete_be.domain.location.service.PlanCostTimeService 0.00% 0 43
com.back.web7_9_codecrete_be.domain.location.controller.KakaoApiController 0.00% 0 43
com.back.web7_9_codecrete_be.domain.artists.entity.Artist 0.00% 0 40
com.back.web7_9_codecrete_be.domain.community.post.service.JoinPostService 0.00% 0 39
com.back.web7_9_codecrete_be.domain.chats.service.ChatPolicyService 0.00% 0 38
com.back.web7_9_codecrete_be.domain.plans.entity.Schedule 0.00% 0 37
com.back.web7_9_codecrete_be.global.security.JwtTokenProvider 0.00% 0 37
com.back.web7_9_codecrete_be.domain.community.post.service.PostService 0.00% 0 36
com.back.web7_9_codecrete_be.domain.location.service.LocationService 0.00% 0 30
com.back.web7_9_codecrete_be.domain.artists.controller.ArtistsController 0.00% 0 28
com.back.web7_9_codecrete_be.domain.plans.entity.Plan 0.00% 0 27
com.back.web7_9_codecrete_be.domain.auth.service.TokenService 0.00% 0 26
com.back.web7_9_codecrete_be.domain.auth.controller.AuthController 0.00% 0 24
Changed Classes (from this PR)
Source (PR) Class Prefix Line % Covered Missed
src/main/java/com/back/web7_9_codecrete_be/domain/concerts/service/KopisApiService.java com.back.web7_9_codecrete_be.domain.concerts.service.KopisApiService 5.17% 15 275
src/main/java/com/back/web7_9_codecrete_be/global/security/SecurityConfig.java com.back.web7_9_codecrete_be.global.security.SecurityConfig 100.00% 27 0

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20702193470

@larama-C larama-C left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@kms152000 kms152000 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리펙터링 수고하셨습니다!

@ys0221 ys0221 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@heygeeji heygeeji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@tobbot16 tobbot16 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재시도 로직(@retryable)에 대해서 저도 알게 되었습니다! 감사합니다
리팩토링도 수고하셨습니다!

@Creamcheesepie Creamcheesepie merged commit 173e835 into main Jan 5, 2026
2 checks passed
@Creamcheesepie Creamcheesepie deleted the feat/#239 branch January 5, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Concert] KOPIS API 데이터 저장 로직 메소드 분리 및 재시도 로직 추가

6 participants