Skip to content

[Location] kakaomap api, tmap api 연동 및 구현 및 환경변수 추가#50

Merged
Creamcheesepie merged 5 commits into
mainfrom
feat/#34
Dec 15, 2025
Merged

[Location] kakaomap api, tmap api 연동 및 구현 및 환경변수 추가#50
Creamcheesepie merged 5 commits into
mainfrom
feat/#34

Conversation

@tobbot16
Copy link
Copy Markdown
Collaborator

@tobbot16 tobbot16 commented Dec 12, 2025 •
edited
Loading

🔗 관련 이슈

관련된 이슈 번호를 연결해주세요.
Close #이슈번호 를 쓰면 PR merge 시 자동으로 close 됩니다.

🚀 PR 개요

이 PR이 어떤 변경을 포함하고 있는지 간단히 설명해주세요.

  • 좌표를 입력하면 좌표 기준으로 1km 반경 이내의 음식점을 알려줍니다 (추천기능은 아직)
  • 시작 좌표, 도착 좌표를 입력하면 tmap api에서 추천 경로를 알려줍니다.
  • 환경변수 값 추가했습니다

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

  • 기능 추가
  • 버그 수정
  • 리팩터링
  • 문서 업데이트
  • 테스트 추가/수정

🧪 테스트 방법

변경된 내용을 어떻게 테스트했는지 구체적으로 적어주세요.

  1. 카카오맵 api : http://localhost:8080/api/test/kakao-restaurants
  2. tmap api : http://localhost:8080/api/tmap/transit?startX=126.925073&startY=37.556516&endX=127.027636&endY=37.497950

📸 스크린샷 (선택)

UI 변경 또는 시각적으로 확인할 수 있는 변경이 있다면 첨부해주세요.

⚠️ 참고 사항

리뷰어가 알아야 할 사항이 있다면 자유롭게 작성해주세요.

@tobbot16 tobbot16 changed the title [Location] kakaomap api, tmap api 연동 및 구현 [Location] kakaomap api, tmap api 연동 및 구현 및 환경변수 추가 Dec 12, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 12, 2025 •
edited
Loading

Test Results

1 tests  ±0   0 ✅  - 1   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ +1 

For more details on these failures, see this check.

Results for commit 2fed0f8. ± Comparison against base commit d578a50.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 12, 2025 •
edited
Loading

⭐ JaCoCo Coverage

Line Coverage: 10.77%

📄 Coverage Details

Overall Line Coverage: 10.69% (76 covered / 711 lines)

Package Summary (lowest first)
Package Line % Covered Missed
com/back/web7_9_codecrete_be/domain/chats/controller 0.00% 0 0
com/back/web7_9_codecrete_be/domain/location/service 0.00% 0 25
com/back/web7_9_codecrete_be/domain/chats/service 0.00% 0 0
com/back/web7_9_codecrete_be/domain/plans/controller 0.00% 0 10
com/back/web7_9_codecrete_be/domain/location/controller 0.00% 0 4
com/back/web7_9_codecrete_be/global/rsData 0.00% 0 11
com/back/web7_9_codecrete_be/domain/location/entity 0.00% 0 0
com/back/web7_9_codecrete_be/domain/auth/service 0.00% 0 55
com/back/web7_9_codecrete_be/domain/plans/service 0.00% 0 80
com/back/web7_9_codecrete_be/domain/users/controller 0.00% 0 0
com/back/web7_9_codecrete_be/domain/email/entity 0.00% 0 6
com/back/web7_9_codecrete_be/domain/users/service 0.00% 0 0
com/back/web7_9_codecrete_be/domain/auth/controller 0.00% 0 20
com/back/web7_9_codecrete_be/domain/concerts/controller 0.00% 0 3
com/back/web7_9_codecrete_be/domain/artists/controller 0.00% 0 0
com/back/web7_9_codecrete_be/domain/artists/service 0.00% 0 0
com/back/web7_9_codecrete_be/global/aspect 0.00% 0 4
com/back/web7_9_codecrete_be/domain/email/service 1.92% 1 51
com/back/web7_9_codecrete_be/domain/concerts/service 6.12% 12 184
com/back/web7_9_codecrete_be/domain/concerts/entity 8.57% 3 32
com/back/web7_9_codecrete_be/global/rq 12.90% 4 27
com/back/web7_9_codecrete_be/global/security 18.52% 15 66
com/back/web7_9_codecrete_be/domain/plans/entity 20.00% 11 44
com/back/web7_9_codecrete_be/domain/users/entity 35.00% 7 13
com/back/web7_9_codecrete_be/domain/chats/entity 100.00% 1 0
com/back/web7_9_codecrete_be/global/doc 100.00% 17 0
com/back/web7_9_codecrete_be/domain/artists/entity 100.00% 5 0
Lowest Covered Classes (Top 20)
Class Line % Covered Missed
com.back.web7_9_codecrete_be.domain.plans.service.PlanService 0.00% 0 80
com.back.web7_9_codecrete_be.domain.auth.service.AuthService 0.00% 0 39
com.back.web7_9_codecrete_be.global.security.JwtTokenProvider 0.00% 0 37
com.back.web7_9_codecrete_be.domain.auth.controller.AuthController 0.00% 0 20
com.back.web7_9_codecrete_be.domain.concerts.entity.Concert 0.00% 0 18
com.back.web7_9_codecrete_be.domain.plans.entity.Route 0.00% 0 18
com.back.web7_9_codecrete_be.domain.plans.entity.Plan 0.00% 0 16
com.back.web7_9_codecrete_be.domain.auth.service.TokenService 0.00% 0 16
com.back.web7_9_codecrete_be.global.security.JwtAuthenticationFilter 0.00% 0 16
com.back.web7_9_codecrete_be.domain.location.service.TmapService 0.00% 0 13
com.back.web7_9_codecrete_be.domain.users.entity.User 0.00% 0 13
com.back.web7_9_codecrete_be.domain.location.service.KakaoLocalService 0.00% 0 12
com.back.web7_9_codecrete_be.global.rsData.RsData 0.00% 0 11
com.back.web7_9_codecrete_be.domain.plans.controller.PlanController 0.00% 0 10
com.back.web7_9_codecrete_be.domain.plans.entity.PlanParticipant 0.00% 0 10
com.back.web7_9_codecrete_be.global.security.CustomUserDetail 0.00% 0 10
com.back.web7_9_codecrete_be.domain.concerts.entity.ConcertPlace 0.00% 0 9
com.back.web7_9_codecrete_be.domain.email.entity.VerificationCode 0.00% 0 6
com.back.web7_9_codecrete_be.domain.concerts.entity.TicketOffice 0.00% 0 5
com.back.web7_9_codecrete_be.global.aspect.ResponseAspect 0.00% 0 4
Changed Classes (from this PR)
Source (PR) Class Prefix Line % Covered Missed
src/main/java/com/back/web7_9_codecrete_be/domain/location/service/TmapService.java com.back.web7_9_codecrete_be.domain.location.service.TmapService 0.00% 0 13
src/main/java/com/back/web7_9_codecrete_be/domain/location/service/KakaoLocalService.java com.back.web7_9_codecrete_be.domain.location.service.KakaoLocalService 0.00% 0 12
src/main/java/com/back/web7_9_codecrete_be/domain/location/controller/KakaoTestController.java com.back.web7_9_codecrete_be.domain.location.controller.KakaoTestController 0.00% 0 3
src/main/java/com/back/web7_9_codecrete_be/domain/location/controller/TmapController.java com.back.web7_9_codecrete_be.domain.location.controller.TmapController 0.00% 0 1
src/main/java/com/back/web7_9_codecrete_be/domain/location/dto/KakaoLocalResponse.java com.back.web7_9_codecrete_be.domain.location.dto.KakaoLocalResponse 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/location/dto/TmapResponse.java com.back.web7_9_codecrete_be.domain.location.dto.TmapResponse 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/global/config/WebClientConfig.java com.back.web7_9_codecrete_be.global.config.WebClientConfig 0.00% 0 0

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20217599259

@Creamcheesepie
Copy link
Copy Markdown
Collaborator

Creamcheesepie commented Dec 15, 2025

빌드 관련 오류가 나오는 것 같은데 확인 부탁드립니다.

@larama-C
Copy link
Copy Markdown
Collaborator

larama-C commented Dec 15, 2025

빌드 관련 오류가 나오는 것 같은데 확인 부탁드립니다.

아마 해당 부분 CI에 TMAP API키가 추가가 안되어있는걸로 확인됩니다.

larama-C
larama-C approved these changes Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@larama-C larama-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

heygeeji
heygeeji approved these changes Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@heygeeji heygeeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! pull 해보시고 문제 없으면 merge하면 될 것 같습니다

ys0221
ys0221 reviewed Dec 15, 2025
View reviewed changes
Comment thread src/main/java/com/back/web7_9_codecrete_be/domain/location/controller/TmapController.java

@RestController
@RequiredArgsConstructor
@RequestMapping("/api/tmap")
Copy link
Copy Markdown
Collaborator

@ys0221 ys0221 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL 에 v1 추가해주시면 감사하겠습니당

Copy link
Copy Markdown
Collaborator Author

@tobbot16 tobbot16 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 까먹고 있었는데 말씀해주셔서 감사합니다

@Creamcheesepie Creamcheesepie merged commit cac7012 into main Dec 15, 2025
1 check passed
@Creamcheesepie Creamcheesepie deleted the feat/#34 branch December 15, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ys0221 ys0221 ys0221 left review comments

@larama-C larama-C larama-C approved these changes

@heygeeji heygeeji heygeeji approved these changes

Assignees

@tobbot16 tobbot16

Labels

Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Location] 카카오맵 api 연결

5 participants

@tobbot16 @Creamcheesepie @larama-C @ys0221 @heygeeji