[Auth] Redis 도입 및 피드백 리팩토링#53
Merged
Merged
Conversation
⭐ JaCoCo CoverageLine Coverage: 11.31% 📄 Coverage DetailsOverall Line Coverage: 11.22% (79 covered / 704 lines) Package Summary (lowest first)
Lowest Covered Classes (Top 20)
Changed Classes (from this PR)
🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20165676192 |
heygeeji
reviewed
Dec 12, 2025
Comment on lines
1
to
+5
| spring: | ||
| data: | ||
| redis: | ||
| host: localhost | ||
| port: 6379 |
Collaborator
There was a problem hiding this comment.
application-test.yml에도 이 부분을 추가하면 CI 실행에 문제 없을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
방금 커밋해서 테스트 잘 돌아가는거 확인했습니다! 감사합니다!
Creamcheesepie
approved these changes
Dec 15, 2025
| public class EmailSendRequest { | ||
|
|
||
| @NotBlank(message = "이메일은 필수입니다.") | ||
| @Email(message = "이메일 형식이 올바르지 않습니다.") |
Collaborator
There was a problem hiding this comment.
@Email 어노테이션은 생각보다 검증을 탄탄해주게 하지 않아서 해당 부분은 정규식으로 수정하는 게 좋을 것 같습니다.
관련 링크
Collaborator
Author
There was a problem hiding this comment.
확인했습니다! 추후 반영하겠습니다!
|
|
||
| @NotBlank(message = "인증 코드는 필수입니다.") | ||
| @Pattern( | ||
| regexp = "^[A-Z0-9]{6}$", |
Collaborator
There was a problem hiding this comment.
정규표현식 처리하신 것 잘하신 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
🚀 PR 개요
📌 변경 사항
🧪 테스트 방법
📸 스크린샷 (선택)