[Concerts] 공연 목록 조회, 공연 상세 조회, 공연 예매처 조회 추가#54
Merged
Merged
Conversation
⭐ JaCoCo CoverageLine Coverage: 10.66% 📄 Coverage DetailsOverall Line Coverage: 10.57% (76 covered / 719 lines) Package Summary (lowest first)
Lowest Covered Classes (Top 20)
Changed Classes (from this PR)
🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20216870564 |
ys0221
reviewed
Dec 15, 2025
| @Schema(description = "조회 기준이 되는 concertId입니다. ?concertId={concertId} 로 값을 넘기시면 됩니다.") | ||
| long concertId | ||
| ) { | ||
| return concertService.getConcertDetail(concertId); |
Collaborator
There was a problem hiding this comment.
여기도 다른 함수들처럼 RsData.success 로 통일하는게 더 좋을 것 같습니다!
larama-C
approved these changes
Dec 15, 2025
|
|
||
| @RestController | ||
| @RequestMapping("api/v1/concerts/") | ||
| @Controller |
Collaborator
There was a problem hiding this comment.
Controller가 RestController와 중복되서 빼셔도 될 것 같습니다!
| this.ticketTime = ticketTime; | ||
| this.startDate = startDate; | ||
| this.endDate = endDate; | ||
| this.createdDate = LocalDateTime.now(); |
Collaborator
There was a problem hiding this comment.
JPA Auditing을 사용하고 있어서, createdDate와 modifiedDate는 CreatedDate, LastModifiedDate 어노테이션 사용하시면 될 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
저는 뭔가... JPA 기능 쓰는게 영 익숙하지 않아서 잘 안쓰게 되는데, 해당 부분 확인해보겠습니다.
tobbot16
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
🚀 PR 개요
📌 변경 사항
🧪 테스트 방법
📸 스크린샷 (선택)
다가오는 콘서트 목록 조회
콘서트 목록 조회
콘서트 예매처 조회
콘서트 상세 조회