[Plan] CRUD를 위한 전체적인 구조 추가 및 변경#76
Merged
Merged
Conversation
⭐ JaCoCo CoverageLine Coverage: 6.24% 📄 Coverage DetailsOverall Line Coverage: 6.20% (118 covered / 1903 lines) Package Summary (lowest first)
Lowest Covered Classes (Top 20)
Changed Classes (from this PR)
🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20252522169 |
ys0221
reviewed
Dec 16, 2025
| PlanResponse planResponse = planService.createPlan(concertId, request); | ||
| User user = rq.getUser(); | ||
| PlanResponse planResponse = planService.createPlan(user, request); | ||
| return RsData.success(HttpStatus.CREATED, "계획 생성 성공", planResponse); |
Collaborator
There was a problem hiding this comment.
RsData.success 부분 다른 함수들과 통일시켜주시면 좋을 것 같습니다!!
Collaborator
Author
There was a problem hiding this comment.
바로 수정하겠습니다! 감사합니다.
| @Size(max = 30, message = "날짜는 30자 이하여야 합니다.") | ||
| private String date; | ||
| @NotNull(message = "날짜는 필수입니다.") | ||
| private LocalDate planDate; |
Collaborator
There was a problem hiding this comment.
LocalDate 부분도 데이터 검증이 가능합니다. 해당 부분 찾아보시고 추가해주시면 좋을 것 같습니다.
Collaborator
Author
There was a problem hiding this comment.
확인 감사합니다! 바로 수정해보겠습니다.
Creamcheesepie
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
🚀 PR 개요
📌 변경 사항