Skip to content

Commit 809fed8

Browse files
committed
refactor: clean up Placer component and styles, update type definitions
1 parent cc24c67 commit 809fed8

4 files changed

Lines changed: 24 additions & 45 deletions

File tree

packages/primereact/src/placer/Placer.props.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,3 @@ export const defaultProps: PlacerProps = {
55
...HeadlessPlacer.defaultProps,
66
as: 'div'
77
};
8-
9-
// export const defaultProps: PlacerProps = {
10-
// ...HeadlessPlacer.defaultProps,
11-
// ...defaultMotionProps,
12-
// animateOnEnter: true,
13-
// animateOnLeave: true,
14-
// enterFromClassName: 'p-placer-content-enter-from',
15-
// enterToClassName: 'p-placer-content-enter-to',
16-
// enterActiveClassName: 'p-placer-content-enter-active',
17-
// leaveFromClassName: 'p-placer-content-leave-from',
18-
// leaveToClassName: 'p-placer-content-leave-to',
19-
// leaveActiveClassName: 'p-placer-content-leave-active',
20-
// shouldAnimateOnEnter: true,
21-
// shouldAnimateOnLeave: true
22-
// };
Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use client';
22
import { Component } from '@primereact/core/component';
33
import { usePlacer } from '@primereact/headless/placer';
4-
import { styles } from '@primereact/styles/popover';
54
import { mergeProps } from '@primeuix/utils';
65
import { withComponent } from 'primereact/base';
76
import * as React from 'react';
@@ -13,7 +12,6 @@ import { PlacerArrow } from './arrow';
1312
export const Placer = withComponent({
1413
name: 'Placer',
1514
defaultProps,
16-
styles,
1715
setup(instance) {
1816
const placer = usePlacer(instance.inProps);
1917

@@ -37,7 +35,9 @@ export const Placer = withComponent({
3735
);
3836

3937
return (
38+
// @ts-expect-error - Temporary fix for elementRef property access
4039
<PlacerProvider value={instance}>
40+
{/* @ts-expect-error - Temporary fix for elementRef property access */}
4141
<Component instance={instance} attrs={rootProps} children={props.children} />
4242
</PlacerProvider>
4343
);
@@ -47,29 +47,3 @@ export const Placer = withComponent({
4747
Anchor: PlacerAnchor
4848
}
4949
});
50-
51-
// const porp={
52-
// in: props.in,
53-
// enterFromClassName: props.shouldAnimateOnEnter ? props.enterFromClassName : undefined,
54-
// enterToClassName: props.shouldAnimateOnEnter ? props.enterToClassName : undefined,
55-
// enterActiveClassName: props.shouldAnimateOnEnter ? props.enterActiveClassName : undefined,
56-
// leaveFromClassName: props.shouldAnimateOnLeave ? props.leaveFromClassName : undefined,
57-
// leaveToClassName: props.shouldAnimateOnLeave ? props.leaveToClassName : undefined,
58-
// leaveActiveClassName: props.shouldAnimateOnLeave ? props.leaveActiveClassName : undefined,
59-
// onBeforeEnter: (e: Element | undefined) => {
60-
// props?.onBeforeEnter?.(e);
61-
// placer?.onBeforeEnter?.(e);
62-
// },
63-
// onLeave: () => {
64-
// placer?.onLeave?.();
65-
// props?.onLeave?.();
66-
// },
67-
// onEnter: () => {
68-
// placer?.onEnter?.();
69-
// props?.onEnter?.();
70-
// },
71-
// onBeforeLeave: () => {
72-
// placer?.onBeforeLeave?.();
73-
// props?.onBeforeLeave?.();
74-
// },
75-
// }

packages/styles/src/tooltip/Tooltip.style.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,26 @@ const style = `
4343
.p-tooltip2-arrow[data-side='bottom'] {
4444
transform: translateY(50%) rotate(135deg);
4545
}
46+
47+
.p-placer-content-enter-from,
48+
.p-placer-content-leave-to {
49+
opacity: 0;
50+
transform: scale(0.9);
51+
}
52+
53+
.p-placer-content-enter-to,
54+
.p-placer-content-leave-from {
55+
opacity: 1;
56+
transform: scale(1);
57+
}
58+
59+
.p-placer-content-leave-active,
60+
.p-placer-content-enter-active {
61+
transition:
62+
opacity 250ms cubic-bezier(0.16, 1, 0.3, 1),
63+
transform 250ms cubic-bezier(0.16, 1, 0.3, 1);
64+
}
65+
4666
`;
4767

4868
export const styles = createStyles<TooltipInstance>({

packages/types/src/shared/placer/usePlacer.types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ export interface usePlacerState {
4646
/**
4747
* The effective side of the placer.
4848
*/
49-
effectiveSide: SideType;
49+
effectiveSide: SideType | null | undefined;
5050
/**
5151
* The effective align of the placer.
5252
*/
53-
effectiveAlign: AlignType;
53+
effectiveAlign: AlignType | null | undefined;
5454
}
5555

5656
/**

0 commit comments

Comments
 (0)