Skip to content

Commit d31b3a5

Browse files
refactor: Knob prop fixes
1 parent a6e33e5 commit d31b3a5

4 files changed

Lines changed: 6 additions & 12 deletions

File tree

packages/@primereact/headless/src/knob/useKnob.props.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export const defaultProps: useKnobProps = {
1414
tabIndex: undefined,
1515
disabled: undefined,
1616
readOnly: undefined,
17+
invalid: undefined,
1718
ariaLabelledby: undefined,
1819
ariaLabel: undefined,
1920
onValueChange: undefined

packages/@primereact/types/src/headless/knob/useKnob.types.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,16 @@ export interface useKnobProps {
7979
* @default 0
8080
*/
8181
tabIndex?: number | undefined;
82+
/**
83+
* When present, it specifies that the component should have invalid state style.
84+
*/
85+
invalid?: boolean | undefined;
8286
/**
8387
* When present, it specifies that the component should be disabled.
84-
* @default false
8588
*/
8689
disabled?: boolean | undefined;
8790
/**
8891
* When present, it specifies that the component value cannot be edited.
89-
* @default false
9092
*/
9193
readOnly?: boolean | undefined;
9294
/**

packages/@primereact/types/src/primitive/knob/KnobRoot.types.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
*
1010
*/
1111
import type { ComponentInstance } from '@primereact/types/core';
12-
import type { BaseComponentProps, PassThroughType } from '../..';
1312
import type { useKnobChangeEvent, useKnobExposes, useKnobProps, useKnobState } from '@primereact/types/headless/knob';
13+
import type { BaseComponentProps, PassThroughType } from '../..';
1414

1515
/**
1616
* Defines passthrough(pt) options type in Knob component.
@@ -58,11 +58,6 @@ export interface KnobRootChangeEvent extends useKnobChangeEvent {
5858
* Defines valid properties in Knob component.
5959
*/
6060
export interface KnobRootProps extends BaseComponentProps<KnobRootInstance, Omit<useKnobProps, 'onValueChange'>, KnobRootPassThrough> {
61-
/**
62-
* When present, it specifies that the component should have invalid state style.
63-
* @default false
64-
*/
65-
invalid?: boolean | undefined;
6661
/**
6762
* Callback fired when the knob's value changes.
6863
* @param event The event that triggered the change.

packages/primereact/src/knob/root/KnobRoot.props.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ import { $dt } from '@primeuix/styled';
55
export const defaultRootProps: KnobRootProps = {
66
...HeadlessKnob.defaultProps,
77
as: 'div',
8-
tabIndex: 1,
9-
disabled: false,
10-
readOnly: false,
11-
invalid: false,
128
rangeColor: $dt('knob.range.background').variable,
139
valueColor: $dt('knob.value.background').variable,
1410
textColor: $dt('knob.text.color').variable

0 commit comments

Comments
 (0)