Fix MultiSelect non-unique keys

[rubenochiavone]

Fixes #8049.

[github-actions]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

[melloware]

Weird shouldn't this key make it unique since its using index ?

[melloware]

Please explain why this fixes it?

[rubenochiavone]

Here is the call site of MultiSelectItem in MultiSelectPanel's createItem function:

primereact/components/lib/multiselect/MultiSelectPanel.js

Lines 170 to 188 in 8735633

	<MultiSelectItem
	hostName={props.hostName}
	key={optionKey}
	focusedOptionIndex={props.focusedOptionIndex}
	label={optionLabel}
	option={option}
	style={style}
	index={index}
	template={props.itemTemplate}
	selected={selected}
	onClick={props.onOptionSelect}
	onMouseMove={changeFocusedItemOnHover}
	disabled={disabled}
	className={props.itemClassName}
	checkboxIcon={props.checkboxIcon}
	isUnstyled={isUnstyled}
	ptm={ptm}
	cx={cx}
	/>

Although MultiSelectItem returns a key in every render, it's not being used here and is causing this warning. If we remove the key from MultiSelectItem usage (line 172 above), I'd expect MultiSelectItem returned key was being used, but the non-unique warning still happens - which means it wasn't used. So, currently I don't see any reasonable use for keeping it. Technically, the key being return by MultiSelectItem is not wrong, though, I wonder if could be an issue with the react version being used.

Anyway, feel free to close the PR if you think is not worth it.

[melloware]

yeah that is why i was confused i wonder if its a false positive React warning?

[rubenochiavone]

yeah that is why i was confused i wonder if its a false positive React warning?

Yeah, probably.