Skip to content

Commit 277b2e4

Browse files
fix: restore dark HC contrast for emphasis, attention, severe, and success tokens
All 4 failures were introduced by calibrating dark HC base color steps to red's luminance profile, which moved mid-range steps from dark to medium-brightness, breaking fg/bg pair relationships. Fixes: - display-blue-bgColor-emphasis: blue.4 -> blue.2 in all dark HC variants (all other hues already used step 2; blue used step 4 only because old uncalibrated steps 1-4 were all identical, accidentally passing) - fgColor-success (colorblind/tritanopia HC): blue.8 -> blue.9 (blue.8 got dimmer, blue.5 muted bg got brighter = less contrast) - fgColor-attention (dark HC variants): add yellow.9 override (no dark HC override existed; inherited yellow.8 which got dimmer) - fgColor-severe (dark HC): orange.8 -> orange.9, red.8 -> red.9 (tritanopia uses red for severe; both got dimmer from calibration)
1 parent 01650ce commit 277b2e4

2 files changed

Lines changed: 12 additions & 9 deletions

File tree

src/tokens/functional/color/display.json5

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,16 +182,16 @@
182182
$value: '{base.color.blue.9}',
183183
},
184184
'dark-high-contrast': {
185-
$value: '{base.color.blue.4}',
185+
$value: '{base.color.blue.2}',
186186
},
187187
'dark-dimmed-high-contrast': {
188-
$value: '{base.color.blue.4}',
188+
$value: '{base.color.blue.2}',
189189
},
190190
'dark-protanopia-deuteranopia-high-contrast': {
191-
$value: '{base.color.blue.4}',
191+
$value: '{base.color.blue.2}',
192192
},
193193
'dark-tritanopia-high-contrast': {
194-
$value: '{base.color.blue.4}',
194+
$value: '{base.color.blue.2}',
195195
},
196196
},
197197
},

src/tokens/functional/color/fgColor.json5

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -255,11 +255,11 @@
255255
'dark-dimmed-high-contrast': '{base.color.green.11}',
256256
'light-high-contrast': '#04591f', /* Custom hex between green.5 and green.6: level 5 fails 7:1 vs bgColor-muted, level 6 is too dark to visually differentiate status colors. Same approach as dark HC overrides (PR #1190). */
257257
'dark-protanopia-deuteranopia': '{base.color.blue.7}',
258-
'dark-protanopia-deuteranopia-high-contrast': '{base.color.blue.8}',
258+
'dark-protanopia-deuteranopia-high-contrast': '{base.color.blue.9}',
259259
'light-protanopia-deuteranopia': '{base.color.blue.7}',
260260
'light-protanopia-deuteranopia-high-contrast': '{base.color.blue.8}',
261261
'dark-tritanopia': '{base.color.blue.7}',
262-
'dark-tritanopia-high-contrast': '{base.color.blue.8}',
262+
'dark-tritanopia-high-contrast': '{base.color.blue.9}',
263263
'light-tritanopia': '{base.color.blue.7}',
264264
'light-tritanopia-high-contrast': '{base.color.blue.8}',
265265
},
@@ -313,6 +313,9 @@
313313
},
314314
'org.primer.overrides': {
315315
dark: '{base.color.yellow.8}',
316+
'dark-high-contrast': '{base.color.yellow.9}',
317+
'dark-protanopia-deuteranopia-high-contrast': '{base.color.yellow.9}',
318+
'dark-tritanopia-high-contrast': '{base.color.yellow.9}',
316319
'light-high-contrast': '{base.color.yellow.8}',
317320
'light-protanopia-deuteranopia-high-contrast': '{base.color.yellow.8}',
318321
'light-tritanopia-high-contrast': '{base.color.yellow.8}',
@@ -339,12 +342,12 @@
339342
},
340343
'org.primer.overrides': {
341344
dark: '{base.color.orange.7}',
342-
'dark-high-contrast': '{base.color.orange.8}',
345+
'dark-high-contrast': '{base.color.orange.9}',
343346
'dark-dimmed-high-contrast': '{base.color.orange.10}',
344-
'dark-protanopia-deuteranopia-high-contrast': '{base.color.orange.8}',
347+
'dark-protanopia-deuteranopia-high-contrast': '{base.color.orange.9}',
345348
'light-high-contrast': '{base.color.orange.8}',
346349
'dark-tritanopia': '{base.color.red.7}',
347-
'dark-tritanopia-high-contrast': '{base.color.red.8}',
350+
'dark-tritanopia-high-contrast': '{base.color.red.9}',
348351
'light-tritanopia': '{base.color.red.7}',
349352
'light-tritanopia-high-contrast': '{base.color.red.8}',
350353
'light-protanopia-deuteranopia-high-contrast': '{base.color.orange.8}',

0 commit comments

Comments
 (0)