fix(ollama): handle Length, Unknown, ContentFilter, Other finish reasons (#943)

Author: ChrisThompsonTLDR

src/Providers/Ollama/Handlers/Text.php

@@ -48,8 +48,14 @@ public function handle(Request $request): Response
             return $this->handleToolCalls($data, $request);
         }
 
-        return match ($this->mapFinishReason($data)) {
-            FinishReason::Stop => $this->handleStop($data, $request),
+        $finishReason = $this->mapFinishReason($data);
+
+        return match ($finishReason) {
+            FinishReason::Stop,
+            FinishReason::Length,
+            FinishReason::Unknown,
+            FinishReason::ContentFilter,
+            FinishReason::Other => $this->handleStop($data, $request),
             default => throw new PrismException('Ollama: unknown finish reason'),
         };
     }

tests/Fixtures/ollama/generate-text-with-done-reason-length-1.json

@@ -0,0 +1 @@
+{"model":"qwen2.5:14b","created_at":"2025-01-29T23:37:41.068257Z","message":{"role":"assistant","content":"I'm Qwen, a large language model developed by Alibaba Cloud. I'm designed to assist with a wide range of tasks including but not limited to answering questions, generating text, offering suggestions, and providing information based on the input I receive. How can I help you today?"},"done_reason":"length","done":true,"total_duration":4819895166,"load_duration":27509166,"prompt_eval_count":33,"prompt_eval_duration":492000000,"eval_count":57,"eval_duration":4298000000}

tests/Fixtures/ollama/generate-text-with-done-reason-unknown-1.json

@@ -0,0 +1 @@
+{"model":"qwen2.5:14b","created_at":"2025-01-29T23:37:41.068257Z","message":{"role":"assistant","content":"I'm Qwen, a large language model developed by Alibaba Cloud. I'm designed to assist with a wide range of tasks including but not limited to answering questions, generating text, offering suggestions, and providing information based on the input I receive. How can I help you today?"},"done_reason":"custom","done":true,"total_duration":4819895166,"load_duration":27509166,"prompt_eval_count":33,"prompt_eval_duration":492000000,"eval_count":57,"eval_duration":4298000000}

tests/Providers/Ollama/TextTest.php

@@ -266,3 +266,29 @@
         });
     });
 });
+describe('Finish reason handling', function (): void {
+    it('returns response when done_reason is length (max tokens)', function (): void {
+        FixtureResponse::fakeResponseSequence('api/chat', 'ollama/generate-text-with-done-reason-length');
+
+        $response = Prism::text()
+            ->using('ollama', 'qwen2.5:14b')
+            ->withPrompt('Who are you?')
+            ->asText();
+
+        expect($response->text)->not->toBeEmpty();
+        expect($response->steps)->toHaveCount(1);
+        expect($response->steps[0]->finishReason->value)->toBe('length');
+    });
+
+    it('returns response when done_reason is unknown (treats as stop)', function (): void {
+        FixtureResponse::fakeResponseSequence('api/chat', 'ollama/generate-text-with-done-reason-unknown');
+
+        $response = Prism::text()
+            ->using('ollama', 'qwen2.5:14b')
+            ->withPrompt('Who are you?')
+            ->asText();
+
+        expect($response->text)->not->toBeEmpty();
+        expect($response->steps)->toHaveCount(1);
+    });
+});