Skip to content

Commit d3ccc56

Browse files
committed
Add better ConnectorError handling in case the advisory lock fails to be parsed to a boolean
1 parent 3f00f18 commit d3ccc56

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

  • schema-engine/connectors/sql-schema-connector/src/flavour

schema-engine/connectors/sql-schema-connector/src/flavour/postgres.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,13 @@ const MIGRATE_ADVISORY_LOCK_ID: i64 = 72707369;
388388
let acquired = result
389389
.first()
390390
.and_then(|row| row.at(0).and_then(|v| v.as_bool()))
391-
.unwrap_or(false);
391+
.ok_or_else(|| {
392+
ConnectorError::from_msg(
393+
"Unexpected result from pg_try_advisory_lock(72707369): \
394+
expected a single boolean column."
395+
.to_owned(),
396+
)
397+
})?;
392398

393399
if !acquired {
394400
return Err(ConnectorError::from_msg(format!(

0 commit comments

Comments
 (0)