Skip to content

fix(mongodb): skip $$REMOVE check for required fields to enable index usage #5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kkartik14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mongodb): skip $$REMOVE check for required fields to enable index usage #5724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions query-engine/connectors/mongodb-query-connector/src/filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,10 @@ impl MongoFilterVisitor {
ScalarCondition::NotSearch(_, _) => unimplemented!("Full-text search is not supported yet on MongoDB"),
};

let filter_doc = if !is_set_cond {
// Only add $$REMOVE check for optional fields. Required fields and _id cannot
// be missing by definition, and adding this check prevents MongoDB from using indexes.
// See: https://github.com/prisma/prisma/issues/29000
let filter_doc = if !is_set_cond && !field.is_required() {
exclude_undefineds(&field_name, self.invert_undefined_exclusion(), filter_doc)
} else {
filter_doc
Expand Down Expand Up @@ -413,7 +416,10 @@ impl MongoFilterVisitor {
)),
}?;

let filter_doc = if !is_set_cond {
// Only add $$REMOVE check for optional fields. Required fields and _id cannot
// be missing by definition, and adding this check prevents MongoDB from using indexes.
// See: https://github.com/prisma/prisma/issues/29000
let filter_doc = if !is_set_cond && !field.is_required() {
exclude_undefineds(&field_name, self.invert_undefined_exclusion(), filter_doc)
} else {
filter_doc
Expand Down
Loading