fix: address Copilot review feedback

Author: DiluDevX

deployment-platforms/rest-express-docker-aws-ec2/.github/workflows/deploy.yml

@@ -69,6 +69,12 @@ jobs:
               docker rm "$CONTAINER_NAME"
             fi
 
+            # Run database migrations
+            docker run --rm \
+              -e DATABASE_URL="${{ secrets.DATABASE_URL }}" \
+              "$ECR_REGISTRY/$ECR_REPOSITORY:${{ github.sha }}" \
+              npx prisma migrate deploy
+
             # Run new container
             docker run -d \
               --name "$CONTAINER_NAME" \

deployment-platforms/rest-express-docker-aws-ec2/Dockerfile

@@ -6,7 +6,7 @@ WORKDIR /app
 COPY package*.json ./
 COPY prisma ./prisma
 COPY prisma.config.ts ./
-RUN npm ci
+RUN npm install
 RUN npx prisma generate
 
 COPY tsconfig.json ./
@@ -23,7 +23,7 @@ RUN addgroup -S appgroup && adduser -S appuser -G appgroup
 COPY package*.json ./
 COPY prisma ./prisma
 COPY prisma.config.ts ./
-RUN npm ci --omit=dev
+RUN npm install --omit=dev
 
 COPY --from=builder /app/dist ./dist
 COPY --from=builder /app/prisma/generated ./prisma/generated

deployment-platforms/rest-express-docker-aws-ec2/README.md

@@ -160,4 +160,4 @@ In your repository, go to **Settings → Secrets and variables → Actions** and
 
 ### 3. How deployment works
 
-Pushing to `main` triggers [`.github/workflows/deploy.yml`](./.github/workflows/deploy.yml). The workflow authenticates with AWS, builds a Docker image using Buildx (with GitHub Actions layer caching for faster rebuilds) and pushes it to ECR tagged with both the commit SHA and `latest`. It then SSHs into your EC2 instance, pulls the new image, gracefully stops and removes the old container if one exists, starts the new one with `DATABASE_URL` injected at runtime, waits 5 seconds and verifies the container is running — printing logs and exiting non-zero if it isn't. Finally it prunes old images to keep the EC2 disk clean.
+Copy [`.github/workflows/deploy.yml`](./.github/workflows/deploy.yml) to `.github/workflows/` at the root of **your own repository**. Pushing to `main` then triggers the workflow. It authenticates with AWS, builds a Docker image using Buildx (with GitHub Actions layer caching for faster rebuilds) and pushes it to ECR tagged with both the commit SHA and `latest`. It then SSHs into your EC2 instance, runs `prisma migrate deploy` against your production database using a one-off container, pulls the new image, gracefully stops and removes the old container if one exists, starts the new one with `DATABASE_URL` injected at runtime, waits 5 seconds and verifies the container is running — printing logs and exiting non-zero if it isn't. Finally it prunes old images to keep the EC2 disk clean.

deployment-platforms/rest-express-docker-aws-ec2/package.json

@@ -12,13 +12,13 @@
     "@prisma/client": "7.0.0",
     "dotenv": "^17.2.1",
     "express": "5.1.0",
-    "pg": "^8.16.3"
+    "pg": "^8.16.3",
+    "prisma": "7.0.0"
   },
   "devDependencies": {
     "@types/express": "5.0.5",
     "@types/node": "22.18.12",
     "@types/pg": "^8.15.6",
-    "prisma": "7.0.0",
     "tsx": "^4.20.6",
     "typescript": "5.8.2"
   }

deployment-platforms/rest-express-docker-aws-ec2/prisma/migrations/20240101000000_init/migration.sql

@@ -0,0 +1,25 @@
+-- CreateTable
+CREATE TABLE "User" (
+    "id" SERIAL NOT NULL,
+    "email" TEXT NOT NULL,
+    "name" TEXT,
+
+    CONSTRAINT "User_pkey" PRIMARY KEY ("id")
+);
+
+-- CreateTable
+CREATE TABLE "Post" (
+    "id" SERIAL NOT NULL,
+    "title" TEXT NOT NULL,
+    "content" TEXT,
+    "published" BOOLEAN NOT NULL DEFAULT false,
+    "authorId" INTEGER NOT NULL,
+
+    CONSTRAINT "Post_pkey" PRIMARY KEY ("id")
+);
+
+-- CreateIndex
+CREATE UNIQUE INDEX "User_email_key" ON "User"("email");
+
+-- AddForeignKey
+ALTER TABLE "Post" ADD CONSTRAINT "Post_authorId_fkey" FOREIGN KEY ("authorId") REFERENCES "User"("id") ON DELETE RESTRICT ON UPDATE CASCADE;

deployment-platforms/rest-express-docker-aws-ec2/prisma/migrations/migration_lock.toml

@@ -0,0 +1,3 @@
+# Please do not edit this file manually
+# It should be added in your version-control system (e.g., Git)
+provider = "postgresql"

deployment-platforms/rest-express-docker-aws-ec2/src/routes/post.routes.ts

@@ -1,4 +1,5 @@
 import { Router, Request, Response } from 'express'
+import { Prisma } from '../../prisma/generated/client'
 import { prisma } from '../lib/prisma'
 
 export const postRouter = Router()
@@ -15,8 +16,13 @@ postRouter.get('/feed', async (_req: Request, res: Response) => {
 // GET /post/:id — single post by id
 postRouter.get('/post/:id', async (req: Request, res: Response) => {
   const { id } = req.params
+  const postId = Number(id)
+  if (!Number.isInteger(postId)) {
+    res.status(400).json({ error: `Invalid post ID: ${id}` })
+    return
+  }
   const post = await prisma.post.findUnique({
-    where: { id: Number(id) },
+    where: { id: postId },
   })
   if (!post) {
     res.status(404).json({ error: `Post with ID ${id} not found` })
@@ -41,26 +47,50 @@ postRouter.post('/post', async (req: Request, res: Response) => {
 // PUT /publish/:id — publish a post
 postRouter.put('/publish/:id', async (req: Request, res: Response) => {
   const { id } = req.params
+  const postId = Number(id)
+  if (!Number.isInteger(postId)) {
+    res.status(400).json({ error: `Invalid post ID: ${id}` })
+    return
+  }
   try {
     const post = await prisma.post.update({
-      where: { id: Number(id) },
+      where: { id: postId },
       data: { published: true },
     })
     res.json(post)
-  } catch {
-    res.status(404).json({ error: `Post with ID ${id} not found` })
+  } catch (error: unknown) {
+    if (
+      error instanceof Prisma.PrismaClientKnownRequestError &&
+      error.code === 'P2025'
+    ) {
+      res.status(404).json({ error: `Post with ID ${id} not found` })
+      return
+    }
+    res.status(500).json({ error: 'Internal server error' })
   }
 })
 
 // DELETE /post/:id — delete post
 postRouter.delete('/post/:id', async (req: Request, res: Response) => {
   const { id } = req.params
+  const postId = Number(id)
+  if (!Number.isInteger(postId)) {
+    res.status(400).json({ error: `Invalid post ID: ${id}` })
+    return
+  }
   try {
     const post = await prisma.post.delete({
-      where: { id: Number(id) },
+      where: { id: postId },
     })
     res.json(post)
-  } catch {
-    res.status(404).json({ error: `Post with ID ${id} not found` })
+  } catch (error: unknown) {
+    if (
+      error instanceof Prisma.PrismaClientKnownRequestError &&
+      error.code === 'P2025'
+    ) {
+      res.status(404).json({ error: `Post with ID ${id} not found` })
+      return
+    }
+    res.status(500).json({ error: 'Internal server error' })
   }
 })

deployment-platforms/rest-express-docker-aws-ec2/tsconfig.json

@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "target": "ES2022",
     "outDir": "dist",
     "strict": true,
     "lib": ["esnext"],