refactor(contract): extract compareCodeUnits helper; trim test comment

Address review on #721: name the deterministic comparator so its intent
reads from the code (not a bare `<`/`>`), and drop the verbose inline
comment from the regression test (the test name carries the intent).
No behavioural change — still UTF-16 code-unit, collation-independent order.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Will Madden <madden@prisma.io>

Author: wmadden

packages/1-framework/0-foundation/contract/src/canonicalization-storage-sort.ts

@@ -11,10 +11,17 @@ function isPlainRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
 
+// Order by UTF-16 code unit, not locale collation: canonicalization feeds
+// storageHash, which must be byte-identical across hosts, and locale
+// collation (localeCompare/Intl) varies by the engine's ICU build.
+function compareCodeUnits(a: string, b: string): number {
+  return a < b ? -1 : a > b ? 1 : 0;
+}
+
 export function compareByNameProperty(a: unknown, b: unknown): number {
   const nameA = isPlainRecord(a) && typeof a['name'] === 'string' ? a['name'] : '';
   const nameB = isPlainRecord(b) && typeof b['name'] === 'string' ? b['name'] : '';
-  return nameA < nameB ? -1 : nameA > nameB ? 1 : 0;
+  return compareCodeUnits(nameA, nameB);
 }
 
 function sortArrayKeysOnRecord(

packages/1-framework/0-foundation/contract/test/canonicalization-storage-sort.test.ts

@@ -97,9 +97,6 @@ describe('compareByNameProperty', () => {
     expect(compareByNameProperty({}, { name: 'a' })).toBeLessThan(0);
   });
 
-  // Locale-independence regression: comparator must use code-unit order, not locale collation.
-  // Code-unit: 'Z' = U+005A < 'a' = U+0061, so { name: 'Z' } sorts before { name: 'a' }.
-  // Most locales sort 'a' before 'Z' (case-insensitive), so localeCompare would return > 0 here.
   it('uses code-unit order, not locale collation (Z < a)', () => {
     expect(compareByNameProperty({ name: 'Z' }, { name: 'a' })).toBeLessThan(0);
   });