chore(skore-mlflow-project): Move from package to python sub-module (#2897)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>

Author: thomass-dev

.github/workflows/pr-display-code-coverage.yml

@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        package: ["skore", "skore-mlflow-project"]
+        package: ["skore"]
     permissions:
       actions: read
       contents: read

.github/workflows/pytest.yml

@@ -39,7 +39,7 @@ defaults:
     shell: bash
 
 env:
-  PACKAGES: '["skore","skore-mlflow-project"]'
+  PACKAGES: '["skore"]'
 
 jobs:
   pytest-changes:
@@ -114,10 +114,10 @@ jobs:
             (echo "${changes}" | (! grep -qE "ci/requirements/${{ matrix.package }}/.*/test-requirements.txt"))
           then
               curl -LsSf https://astral.sh/uv/0.6.16/install.sh | sh
-              bash ci/pip-compile.sh --test-requirements ${{ matrix.package }}
+              bash ci/pip-compile.sh --test-requirements
 
               if (git diff --name-only | grep -qE "ci/requirements/${{ matrix.package }}/.*/test-requirements.txt"); then
-                  echo '::error title=${{ matrix.package }}-test-lockfiles::Lockfiles obsolete, please execute `$ bash ci/pip-compile.sh --test-requirements ${{ matrix.package }}`'
+                  echo '::error title=${{ matrix.package }}-test-lockfiles::Lockfiles obsolete, please execute `$ bash ci/pip-compile.sh --test-requirements`'
                   exit 1
              fi
           fi
@@ -256,13 +256,13 @@ jobs:
 
       - name: Test without coverage
         if: ${{ ! matrix.coverage }}
-        timeout-minutes: 15
+        timeout-minutes: 20
         working-directory: ${{ matrix.package }}/
         run: python -m pytest src/ tests/ --no-cov
 
       - name: Test with coverage
         if: ${{ matrix.coverage }}
-        timeout-minutes: 15
+        timeout-minutes: 20
         working-directory: ${{ matrix.package }}/
         run: |
           mkdir coverage

.github/workflows/release.yml

@@ -32,7 +32,7 @@ jobs:
           version="${GITHUB_REF_NAME#*/}"
 
           [[ "${package}" == "${version}" ]] && { >&2 echo "Invalid tag: no package"; exit 1; }
-          [[ "${package}" =~ ^(skore|skore-mlflow-project)$ ]] || { >&2 echo "Invalid tag: invalid package"; exit 1; }
+          [[ "${package}" =~ ^skore$ ]] || { >&2 echo "Invalid tag: invalid package"; exit 1; }
           [[ "${version}" =~ ^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-rc\.(1|[1-9][0-9]*))?$ ]] || { >&2 echo "Invalid tag: invalid version"; exit 1; }
 
           echo "::group::Details"

.github/workflows/sphinx.yml

@@ -239,7 +239,6 @@ jobs:
       - name: Install all packages from local branch
         run: |
           python -m pip install --force-reinstall --no-deps skore/
-          python -m pip install --force-reinstall --no-deps skore-mlflow-project/
 
       - name: Build documentation
         working-directory: sphinx

.gitignore

@@ -197,7 +197,6 @@ examples/integrations/mlruns/
 
 # Exclude hatch artifacts
 skore/LICENSE
-skore-mlflow-project/LICENSE
 .aider*
 
 # uv

.pre-commit-config.yaml

@@ -20,20 +20,18 @@ repos:
     hooks:
 
       - id: ruff-check
-        files: ^((skore|skore-mlflow-project)/(hatch|src|tests))|(examples)/
+        files: ^(skore/(hatch|src|tests))|(examples)/
         args: [--fix, --extend-select, I]
 
       - id: ruff-format
-        files: ^((skore|skore-mlflow-project)/(hatch|src|tests))|(examples)/
+        files: ^(skore/(hatch|src|tests))|(examples)/
 
   - repo: https://github.com/pre-commit/mirrors-mypy
     rev: v1.20.2
     hooks:
 
       - id: mypy
         pass_filenames: false
-        alias: mypy-skore
-        name: mypy skore/
         files: ^skore/
         args: [--config-file=skore/pyproject.toml, skore]
         additional_dependencies:
@@ -61,11 +59,5 @@ repos:
           - httpx
           - orjson
           - pydantic
-
-      - id: mypy
-        pass_filenames: false
-        alias: mypy-skore-mlflow-project
-        name: mypy skore-mlflow-project/
-        files: ^skore-mlflow-project/
-        args: [--config-file=skore-mlflow-project/pyproject.toml, skore-mlflow-project]
-        additional_dependencies: [skore, mlflow]
+          # from mlflow dependencies
+          - mlflow

ci/pip-compile.sh

@@ -6,13 +6,13 @@
 #
 # You can pass any `uv pip compile` parameter:
 #
-#     $ bash pip-compile.sh --test-requirements <skore|skore-mlflow-project> --upgrade
+#     $ bash pip-compile.sh --test-requirements --upgrade
 #     $ bash pip-compile.sh --sphinx-requirements --upgrade
 #
 
 usage () {
     >&2 echo "Usage:"
-    >&2 echo "    $ bash pip-compile.sh --test-requirements <all|skore|skore-mlflow-project> [option...]"
+    >&2 echo "    $ bash pip-compile.sh --test-requirements [option...]"
     >&2 echo "    $ bash pip-compile.sh --sphinx-requirements [option...]"
 }
 
@@ -26,40 +26,19 @@ trap 'rm -rf ${TMPDIR}' 0
 # Construct `COMBINATIONS` based on arguments
 case $1 in
     "--test-requirements")
-        PACKAGES=()
-
-        case $2 in
-            "all")
-                PACKAGES+=("skore")
-                PACKAGES+=("skore-mlflow-project")
-                ;;
-            "skore"|"skore-mlflow-project")
-                PACKAGES+=($2)
-                ;;
-            *)
-                >&2 echo -e "Error: Unknown PACKAGE \033[0;41m$2\033[0m"
-                usage
-                exit 1
-                ;;
-        esac
-
-        for PACKAGE in "${PACKAGES[@]}"; do
-            while IFS= read -r combination; do
-                python=$(jq -rc '.python' <<< "${combination}")
-                dependencies=$(jq -rc '.dependencies' <<< "${combination}")
-
-                COMBINATIONS+=("${PACKAGE}|test|${python}|${dependencies}")
-            done < <(
-                jq 'unique_by([.python, .dependencies]) | .[]' "${CWD}/../${PACKAGE}/supported-versions.json" -c
-            )
-        done
+        while IFS= read -r combination; do
+            python=$(jq -rc '.python' <<< "${combination}")
+            dependencies=$(jq -rc '.dependencies' <<< "${combination}")
+
+            COMBINATIONS+=("skore|test|${python}|${dependencies}")
+        done < <(
+            jq 'unique_by([.python, .dependencies]) | .[]' "${CWD}/../skore/supported-versions.json" -c
+        )
 
         unset combination
         unset python
         unset dependencies
-        unset PACKAGES
-        unset PACKAGE
-        shift 2
+        shift
         ;;
     "--sphinx-requirements")
         COMBINATIONS+=('skore|sphinx|3.14|["scikit-learn==1.8.*"]')