chore(skore,skore-*-project)!: Remove clear_cache and cache_predictions from public API#2829
Draft
glemaitre wants to merge 1 commit into
Draft
chore(skore,skore-*-project)!: Remove clear_cache and cache_predictions from public API#2829glemaitre wants to merge 1 commit into
glemaitre wants to merge 1 commit into
Conversation
Contributor
glemaitre
changed the title
glemaitre
force-pushed
the
remove_public_interface_cache
branch
from
d0d5fc7 to
afa4457
Compare
…ns from public API
glemaitre
force-pushed
the
remove_public_interface_cache
branch
from
afa4457 to
711bbbd
Compare
Contributor
|
This is typically the kind of things that's much harder too do in a multi-package, you should probably wait for the mono-package architecture change before moving forward here (maybe that's already you're plan). |
Member
Author
|
I wanted to see to now, what is breaking ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is removing the public interface for
clear_cacheandcache_predictions.