Skip to content

fix: restore analyzer spinner animation#87

Open
saurabhhhcodes wants to merge 1 commit into
probably-ABHINAV:mainfrom
saurabhhhcodes:fix/analyzer-spinner-keyframes-36
Open

fix: restore analyzer spinner animation#87
saurabhhhcodes wants to merge 1 commit into
probably-ABHINAV:mainfrom
saurabhhhcodes:fix/analyzer-spinner-keyframes-36

Conversation

@saurabhhhcodes
Copy link
Copy Markdown

Summary

  • restore the missing global @keyframes spin animation used by the analyzer loading spinner
  • allow the shared Skeleton div wrapper to accept normal HTML div props so existing analyzer chart skeletons can pass inline height styles

Fixes #36

Root Cause

The analyzer spinner referenced animation: spin ..., but the app's global stylesheet did not define @keyframes spin, so the loading indicator could render without rotating. While validating the production build, TypeScript also exposed that ChartSkeleton passes style to Skeleton, but Skeleton only accepted className, which blocked a clean build.

Changes Made

  • added a global @keyframes spin rule in apps/web/app/globals.css
  • widened SkeletonProps to React.HTMLAttributes<HTMLDivElement> and forwarded remaining props to the rendered div

Testing

  • npm ci
  • npm --workspace @opscord/web run build
  • npm --workspace @opscord/web run type-check
  • npm --workspace @opscord/web run start -- -p 3016
  • curl -fsS http://localhost:3016/analyzer
  • fetched the built CSS asset from the production server and verified it includes @keyframes spin
  • git diff --check

Notes

  • The build currently warns that GEMINI_API_KEY is not defined, but completes successfully.
  • npm ci reports existing dependency audit warnings; this PR does not change dependencies.
  • I also checked for the requested footer phrase No spam. Only useful updates. across the app and repository. It is not present in this codebase, so no speculative footer edit was made.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2026

Someone is attempting to deploy a commit to the xoxogroovy-7398's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Missing @keyframes spin in globals.css Breaks Analyzer Loading Spinner

1 participant