fix: restore analyzer spinner animation#87
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to the xoxogroovy-7398's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@keyframes spinanimation used by the analyzer loading spinnerSkeletondiv wrapper to accept normal HTML div props so existing analyzer chart skeletons can pass inline height stylesFixes #36
Root Cause
The analyzer spinner referenced
animation: spin ..., but the app's global stylesheet did not define@keyframes spin, so the loading indicator could render without rotating. While validating the production build, TypeScript also exposed thatChartSkeletonpassesstyletoSkeleton, butSkeletononly acceptedclassName, which blocked a clean build.Changes Made
@keyframes spinrule inapps/web/app/globals.cssSkeletonPropstoReact.HTMLAttributes<HTMLDivElement>and forwarded remaining props to the rendered divTesting
npm cinpm --workspace @opscord/web run buildnpm --workspace @opscord/web run type-checknpm --workspace @opscord/web run start -- -p 3016curl -fsS http://localhost:3016/analyzer@keyframes spingit diff --checkNotes
GEMINI_API_KEYis not defined, but completes successfully.npm cireports existing dependency audit warnings; this PR does not change dependencies.No spam. Only useful updates.across the app and repository. It is not present in this codebase, so no speculative footer edit was made.