Unify ChoiceMap and Selection via AddressTree#279
Draft
georgematheos wants to merge 35 commits intoprobcomp:masterfrom
Draft
Unify ChoiceMap and Selection via AddressTree#279georgematheos wants to merge 35 commits intoprobcomp:masterfrom
georgematheos wants to merge 35 commits intoprobcomp:masterfrom
Conversation
…eorgematheos-distributionsasgenfns
georgematheos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a working draft of unifying
ChoiceMaps andSelections into a singleAddressTreetype, as was discussed in my proposal to implement support for "custom update specifications". This is still a draft (eg. I have not updated the documentation fully to reflect these changes), but I wanted to make this progress available for discussion.I will be following up with work changing the
updatefunction. Once I have more time, I will try to put together a more careful explanation for why I think these changes are worth considering, and why the commitments these changes make are reasonable for Gen, and in my view give Gen structure which is pretty fundamental to its design.