-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix --deno-* option parsing and add cache command #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| probitas cache - Cache scenario dependencies | ||
|
|
||
| Usage: probitas cache [options] [paths...] | ||
|
|
||
| Arguments: | ||
| [paths...] Scenario files or directories | ||
| Defaults to current directory | ||
|
|
||
| Options: | ||
| -h, --help Show help message | ||
| -r, --reload Force re-download of cached dependencies | ||
| --include <pattern> Include pattern for file discovery | ||
| --exclude <pattern> Exclude pattern for file discovery | ||
| --config <path> Path to probitas config file | ||
| -v, --verbose Verbose output | ||
| -q, --quiet Suppress output | ||
| -d, --debug Debug output | ||
|
|
||
| Note: | ||
| Runs `deno cache` on discovered scenario files to pre-download dependencies. | ||
| Uses includes/excludes from probitas config (same as run/list). | ||
|
|
||
| Examples: | ||
| probitas cache # Cache dependencies for all scenarios | ||
| probitas cache api/ # Cache dependencies in api directory | ||
| probitas cache -r # Force re-download all dependencies | ||
| probitas cache -r api/ # Force re-download for api directory | ||
| probitas cache --include "e2e/**/*.probitas.ts" | ||
|
|
||
| Documentation: https://probitas-test.github.io/documents/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /** | ||
| * Cache command for Probitas CLI | ||
| * | ||
| * Runs `deno cache` on discovered scenario files to pre-download dependencies. | ||
| * | ||
| * @module | ||
| */ | ||
|
|
||
| import { runDenoSubcommand } from "./_deno.ts"; | ||
|
|
||
| /** | ||
| * Run the cache command | ||
| * | ||
| * @param args - Command-line arguments | ||
| * @param cwd - Current working directory | ||
| * @returns Exit code | ||
| */ | ||
| export async function cacheCommand( | ||
| args: string[], | ||
| cwd: string, | ||
| ): Promise<number> { | ||
| return await runDenoSubcommand("cache", args, cwd, { | ||
| usageAsset: "usage-cache.txt", | ||
| supportReload: true, | ||
| useConfig: true, | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -125,7 +125,16 @@ export async function runCommand( | |||||||||||||
|
|
||||||||||||||
| // Configure logging with determined log level | ||||||||||||||
| await configureLogging(logLevel); | ||||||||||||||
| logger.debug("Run command started", { args, cwd, logLevel, denoArgs }); | ||||||||||||||
|
|
||||||||||||||
| // Add --reload to denoArgs if -r/--reload is specified | ||||||||||||||
| const finalDenoArgs = parsed.reload ? [...denoArgs, "--reload"] : denoArgs; | ||||||||||||||
|
Comment on lines
+129
to
+130
|
||||||||||||||
| // Add --reload to denoArgs if -r/--reload is specified | |
| const finalDenoArgs = parsed.reload ? [...denoArgs, "--reload"] : denoArgs; | |
| // Add --reload to denoArgs if -r/--reload is specified, avoiding duplicates | |
| const finalDenoArgs = parsed.reload && !denoArgs.includes("--reload") | |
| ? [...denoArgs, "--reload"] | |
| : denoArgs; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user provides both
-rand--deno-reload, this will result in duplicate--reloadflags being passed to the Deno subprocess. Consider checking if--reloadis already present indenoArgsbefore adding it.